LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hans Verkuil <email@example.com>
To: Ezequiel Garcia <firstname.lastname@example.org>
Cc: "houlong wei" <email@example.com>,
"Eizan Miyamoto" <firstname.lastname@example.org>,
"Linux Kernel Mailing List" <email@example.com>,
"Yong Wu (吴勇)" <Yong.Wu@mediatek.com>,
"CK Hu (胡俊光)" <firstname.lastname@example.org>,
"Enric Balletbo i Serra" <email@example.com>,
"Yongqiang Niu (牛永强)" <firstname.lastname@example.org>,
"Andrew-CT Chen (陳智迪)" <Andrew-CT.Chen@mediatek.com>,
"Matthias Brugger" <email@example.com>,
"Mauro Carvalho Chehab" <firstname.lastname@example.org>,
"Minghsiu Tsai (蔡明修)" <Minghsiu.Tsai@mediatek.com>,
"moderated list:ARM/Mediatek SoC support"
Subject: Re: [PATCH v7 2/7] mtk-mdp: add driver to probe mdp components
Date: Tue, 7 Dec 2021 14:02:06 +0100 [thread overview]
Message-ID: <email@example.com> (raw)
On 12/7/21 1:46 PM, Ezequiel Garcia wrote:
> Hi everyone,
> On Tue, 7 Dec 2021 at 09:37, Hans Verkuil <firstname.lastname@example.org> wrote:
>> On 9/5/21 6:23 PM, houlong wei wrote:
>>> Hi Ezequiel,
>>> Thank you for your attention to this series of patches. I answer partial of your questions below.
>>> On Sat, 2021-09-04 at 20:34 +0800, Ezequiel Garcia wrote:
>>>> Hi Eizan,
>>>> Sorry for seeing this series so late.
>>>> On Wed, 25 Aug 2021 at 03:35, Eizan Miyamoto <email@example.com>
>>>>> Broadly, this patch (1) adds a driver for various MTK MDP
>>>>> components to
>>>>> go alongside the main MTK MDP driver, and (2) hooks them all
>>>>> using the component framework.
>>>>> (1) Up until now, the MTK MDP driver controls 8 devices in the
>>>>> tree on its own. When running tests for the hardware video decoder,
>>>>> found that the iommus and LARBs were not being properly configured.
>>>> Why were not being properly configured? What was the problem?
>>>> Why not fixing that instead?
>>>> Does this mean the driver is currently broken and unusable?
>>> This series of patches are supplements to another series, please refer
>>> , which add device link between the mtk-iommu consumer and the mtk-larb
>>> devices. Without that series of patches, the mtk-mdp driver can work
>>> well so far.
>>> But with that series, it seems the device link only can be established
>>> for the device which is registered as a platform driver. That's why
>>> Eizan adds this series of patches to make all mdp components to be
>>> registered as platform drivers.
>> Hold on, so this means that if that iommu device-link series is merged,
>> then the mtk-mdp driver breaks? I posted a PR for that iommu series, but
>> I've just withdrawn that PR until this issue is clarified.
>> Is it only mtk-mdp that is affected by this iommu device-link series, or
>> others as well?
> Like I said before, I think it's a mistake to introduce the component
> framework in V4L2. This whole idea looks like a hack to me.
> If we merge this, then we validate using the component framework
> as a way to avoid fixing things properly.
I agree with Ezequiel.
next prev parent reply other threads:[~2021-12-07 13:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 6:33 [PATCH v7 0/7] Refactor MTK MDP driver into core/components Eizan Miyamoto
2021-08-25 6:33 ` [PATCH v7 1/7] mtk-mdp: propagate errors from clock_on Eizan Miyamoto
2021-08-25 6:33 ` [PATCH v7 2/7] mtk-mdp: add driver to probe mdp components Eizan Miyamoto
2021-09-04 12:34 ` Ezequiel Garcia
2021-09-05 16:23 ` houlong wei
2021-09-05 16:39 ` houlong wei
2021-12-07 12:37 ` Hans Verkuil
2021-12-07 12:46 ` Ezequiel Garcia
2021-12-07 13:02 ` Hans Verkuil [this message]
2021-12-08 2:00 ` Yong Wu
2021-08-25 6:33 ` [PATCH v7 3/7] mtk-mdp: use pm_runtime in MDP component driver Eizan Miyamoto
2021-08-25 6:33 ` [PATCH v7 4/7] media: mtk-mdp: don't pm_run_time_get/put for master comp in clock_on Eizan Miyamoto
2021-08-25 6:33 ` [PATCH v7 5/7] mtk-mdp: make mdp driver to be loadable by platform_device_register*() Eizan Miyamoto
2021-08-25 8:18 ` houlong wei
2021-08-25 6:33 ` [PATCH v7 6/7] soc: mediatek: mmsys: instantiate mdp virtual device from mmsys Eizan Miyamoto
2021-08-25 6:33 ` [PATCH v7 7/7] media: mtk-mdp: use mdp-rdma0 alias to point to MDP master Eizan Miyamoto
2021-08-25 8:43 ` houlong wei
2021-08-25 9:07 ` Enric Balletbo i Serra
2021-08-25 15:18 ` houlong wei
2021-08-25 16:54 ` Enric Balletbo i Serra
2021-08-30 17:14 ` houlong wei
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH v7 2/7] mtk-mdp: add driver to probe mdp components' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).