LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: 李扬韬 <frank.li@vivo.com>
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] f2fs: add sysfs nodes to get discard information
Date: Thu, 19 Aug 2021 12:49:36 +0800	[thread overview]
Message-ID: <ee60f940-c1a6-e41d-a163-bf277290c231@kernel.org> (raw)
In-Reply-To: <AGwAWQBVD3NfsYDCdBIWb4qP.3.1629094420548.Hmail.frank.li@vivo.com>

On 2021/8/16 14:13, 李扬韬 wrote:
>>>>> I've added new sysfs nodes to show discard stat since mount, which
>>>>> will help us analyze whether the performance problem is related to
>>>>> discard.
>>>>>
>>>>> issued_discard  - Shows the number of issued discard
>>>>> queued_discard  - Shows the number of cached discard cmd count
>>>>> discard_cmd_cnt - Shows the number of cached discard cmd count
>>>>> undiscard_blks  - Shows the number of undiscard blocks
>>>>
>>>> We have exported them in debugfs, can you use that?
>>>>
>>>> Thanks,
>>>
>>> But now Android is forbidden to open debugfs, and in fact we have not
>>> opened this configuration for a long time.
>>
>> Weren't them be used for debug purpose? can you please explain more about
>> your use case?
> 
> During long-term aging test or normal use, sometimes there will be performance
> degradation problems. It may be caused by storage, or it may be caused by the
> filesystem. For example, the filesystem accumulates a large number of undiscard
>   blocks. Although there is some remaining space, the androidbench test will
> show performance degradation. Therefore, it is necessary to export information
> related to discard so that we can confirm this situation.

I have a solution for your case, however finally, we haven't used such discard
policy by default due to the policy needs to be designed more tunable for
devices with different characters.

See more details in below patches:

https://lkml.org/lkml/2018/8/10/219
https://lkml.org/lkml/2018/8/10/220

Thanks,

> 
> Thx,
> 
> 

      parent reply	other threads:[~2021-08-19  4:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-14 17:58 Yangtao Li
2021-08-14 17:58 ` [PATCH 2/2] f2fs: fix description about main_blkaddr node Yangtao Li
2021-08-16  2:37   ` Chao Yu
2021-08-16  2:35 ` [PATCH 1/2] f2fs: add sysfs nodes to get discard information Chao Yu
2021-08-16  2:42   ` 李扬韬
2021-08-16  4:15     ` Chao Yu
2021-08-16  6:13       ` 李扬韬
2021-08-17  0:16         ` Jaegeuk Kim
2021-08-19  4:49         ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee60f940-c1a6-e41d-a163-bf277290c231@kernel.org \
    --to=chao@kernel.org \
    --cc=frank.li@vivo.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/2] f2fs: add sysfs nodes to get discard information' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).