[PATCH] fs/ceph/export: remove unused variable 'err'

[PATCH] fs/ceph/export: remove unused variable 'err'

[Qiujun Huang]

fix gcc '-Wunused-but-set-variable' warning:
fs/ceph/export.c: In function ‘__get_parent’:
fs/ceph/export.c:294:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
  int err;

and needn't use the return value of ceph_mdsc_create_request.

Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
---
 fs/ceph/export.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ceph/export.c b/fs/ceph/export.c
index b6bfa94..b7bb41c 100644
--- a/fs/ceph/export.c
+++ b/fs/ceph/export.c
@@ -291,7 +291,6 @@ static struct dentry *__get_parent(struct super_block *sb,
 	struct ceph_mds_request *req;
 	struct inode *inode;
 	int mask;
-	int err;
 
 	req = ceph_mdsc_create_request(mdsc, CEPH_MDS_OP_LOOKUPPARENT,
 				       USE_ANY_MDS);
@@ -314,7 +313,7 @@ static struct dentry *__get_parent(struct super_block *sb,
 	req->r_args.getattr.mask = cpu_to_le32(mask);
 
 	req->r_num_caps = 1;
-	err = ceph_mdsc_do_request(mdsc, NULL, req);
+	ceph_mdsc_do_request(mdsc, NULL, req);
 	inode = req->r_target_inode;
 	if (inode)
 		ihold(inode);
-- 
1.8.3.1

Re: [PATCH] fs/ceph/export: remove unused variable 'err'

[Jeff Layton]

On Wed, 2020-03-04 at 00:21 +0800, Qiujun Huang wrote:
> fix gcc '-Wunused-but-set-variable' warning:
> fs/ceph/export.c: In function ‘__get_parent’:
> fs/ceph/export.c:294:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
>   int err;
> 
> and needn't use the return value of ceph_mdsc_create_request.
> 
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> ---
>  fs/ceph/export.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ceph/export.c b/fs/ceph/export.c
> index b6bfa94..b7bb41c 100644
> --- a/fs/ceph/export.c
> +++ b/fs/ceph/export.c
> @@ -291,7 +291,6 @@ static struct dentry *__get_parent(struct super_block *sb,
>  	struct ceph_mds_request *req;
>  	struct inode *inode;
>  	int mask;
> -	int err;
>  
>  	req = ceph_mdsc_create_request(mdsc, CEPH_MDS_OP_LOOKUPPARENT,
>  				       USE_ANY_MDS);
> @@ -314,7 +313,7 @@ static struct dentry *__get_parent(struct super_block *sb,
>  	req->r_args.getattr.mask = cpu_to_le32(mask);
>  
>  	req->r_num_caps = 1;
> -	err = ceph_mdsc_do_request(mdsc, NULL, req);
> +	ceph_mdsc_do_request(mdsc, NULL, req);
>  	inode = req->r_target_inode;
>  	if (inode)
>  		ihold(inode);

I think we probably ought to just return ERR_PTR(err) in that case
instead of discarding it. It looks like today we'll end up returning
ENOENT when that errors out which doesn't seem right when there is a
different issue.

-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH] fs/ceph/export: remove unused variable 'err'

[Qiujun Huang]

On Thu, Mar 5, 2020 at 4:36 AM Jeff Layton <jlayton@kernel.org> wrote:
>
> I think we probably ought to just return ERR_PTR(err) in that case
> instead of discarding it. It looks like today we'll end up returning
> ENOENT when that errors out which doesn't seem right when there is a
> different issue.

I get that, thanks.

>
> --
> Jeff Layton <jlayton@kernel.org>
>