LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] f2fs: clear PageError on writepage
@ 2018-04-13  1:07 Jaegeuk Kim
  2018-04-16  1:52 ` Chao Yu
  0 siblings, 1 reply; 2+ messages in thread
From: Jaegeuk Kim @ 2018-04-13  1:07 UTC (permalink / raw)
  To: linux-kernel, linux-f2fs-devel; +Cc: Jaegeuk Kim

This patch clears PageError in some pages tagged by read path, but when we
write the pages with valid contents, writepage should clear the bit likewise
ext4.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/data.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index db50686f5096..6d39a6e12f78 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1675,6 +1675,7 @@ int do_write_data_page(struct f2fs_io_info *fio)
 			goto out_writepage;
 
 		set_page_writeback(page);
+		ClearPageError(page);
 		f2fs_put_dnode(&dn);
 		if (fio->need_lock == LOCK_REQ)
 			f2fs_unlock_op(fio->sbi);
@@ -1697,6 +1698,7 @@ int do_write_data_page(struct f2fs_io_info *fio)
 		goto out_writepage;
 
 	set_page_writeback(page);
+	ClearPageError(page);
 
 	/* LFS mode write path */
 	write_data_page(&dn, fio);
-- 
2.15.0.531.g2ccb3012c9-goog

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] f2fs: clear PageError on writepage
  2018-04-13  1:07 [PATCH] f2fs: clear PageError on writepage Jaegeuk Kim
@ 2018-04-16  1:52 ` Chao Yu
  0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2018-04-16  1:52 UTC (permalink / raw)
  To: Jaegeuk Kim, linux-kernel, linux-f2fs-devel

On 2018/4/13 9:07, Jaegeuk Kim wrote:
> This patch clears PageError in some pages tagged by read path, but when we
> write the pages with valid contents, writepage should clear the bit likewise
> ext4.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-16  1:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-13  1:07 [PATCH] f2fs: clear PageError on writepage Jaegeuk Kim
2018-04-16  1:52 ` Chao Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).