LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Alexey Zaytsev" <alexey.zaytsev@gmail.com>
To: "Michael Buesch" <mb@bu3sch.de>
Cc: "Larry Finger" <Larry.Finger@lwfinger.net>,
	"Stefano Brivio" <stefano.brivio@polimi.it>,
	"Jeff Garzik" <jgarzik@pobox.com>, "Greg KH" <greg@kroah.com>,
	"Pekka Enberg" <penberg@cs.helsinki.fi>,
	"Ingo Molnar" <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
Date: Sat, 23 Feb 2008 23:37:13 +0300	[thread overview]
Message-ID: <f19298770802231237m520e0158ldce3ae422796ae3b@mail.gmail.com> (raw)
In-Reply-To: <200802231720.21920.mb@bu3sch.de>

On Sat, Feb 23, 2008 at 7:20 PM, Michael Buesch <mb@bu3sch.de> wrote:
> On Saturday 23 February 2008 14:17:55 Alexey Zaytsev wrote:
>  > diff --git a/drivers/net/wireless/bcm43xx/Kconfig b/drivers/net/wireless/bcm43xx/Kconfig
>  > index 0159701..afb8f43 100644
>  > --- a/drivers/net/wireless/bcm43xx/Kconfig
>  > +++ b/drivers/net/wireless/bcm43xx/Kconfig
>  > @@ -1,6 +1,6 @@
>  >  config BCM43XX
>  >       tristate "Broadcom BCM43xx wireless support (DEPRECATED)"
>  > -     depends on PCI && IEEE80211 && IEEE80211_SOFTMAC && WLAN_80211 && EXPERIMENTAL
>  > +     depends on PCI && IEEE80211 && IEEE80211_SOFTMAC && WLAN_80211 && (!SSB_B43_PCI_BRIDGE || SSB != y) && EXPERIMENTAL
>
>  so if SSB is m it will break module auto-loading, right?
>

Right.
If ssb == m, you can at least unload the ssb module manually, or
specify the right
module to load. In the first patch I sent to you, it was
"!SSB_B43_PCI_BRIDGE" instead of
"(!SSB_B43_PCI_BRIDGE || SSB != y)", but I thought that there is no reason to
completely hide the bcm43xx option if ssb is compiled as module.

  reply	other threads:[~2008-02-23 20:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-23 13:17 [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25 Alexey Zaytsev
2008-02-23 16:20 ` Michael Buesch
2008-02-23 20:37   ` Alexey Zaytsev [this message]
2008-02-24 16:26 ` Larry Finger
2008-02-27 20:15   ` John W. Linville
2008-02-27 21:58     ` Michael Buesch
2008-02-28  1:15       ` John W. Linville
2008-02-29  8:21 ` Andrew Morton
2008-02-29 10:05   ` Michael Buesch
2008-02-29 20:54     ` Ingo Molnar
2008-02-29 22:49       ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f19298770802231237m520e0158ldce3ae422796ae3b@mail.gmail.com \
    --to=alexey.zaytsev@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=greg@kroah.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=stefano.brivio@polimi.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).