LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] selftests:intel_pstate: fixes typical crash of a testing script for Intel P-State driver
@ 2018-04-29 19:12 Jeffrin Jose T
  2018-05-04 19:47 ` Shuah Khan
  0 siblings, 1 reply; 4+ messages in thread
From: Jeffrin Jose T @ 2018-04-29 19:12 UTC (permalink / raw)
  To: shuah, kstewart, daniel.diaz, pombredanne, gregkh, thomas
  Cc: linux-kselftest, linux-kernel, Jeffrin Jose T, Jeffrin Jose T

 Testing script for Intel P-State driver crashes during
 the run.  this patch fixes that crash and produce typical results.

Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>

---
 tools/testing/selftests/intel_pstate/run.sh | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
index c670359becc6..cd32aca8806f 100755
--- a/tools/testing/selftests/intel_pstate/run.sh
+++ b/tools/testing/selftests/intel_pstate/run.sh
@@ -27,6 +27,7 @@
 # and the test will error out in those cases.  The result.X file can be checked
 # for consistency and modified to remove the extra MHz values.  The result.X
 # files can be re-evaluated by setting EVALUATE_ONLY to 1 below.
+#set -xv
 
 EVALUATE_ONLY=0
 
@@ -101,12 +102,13 @@ cpupower frequency-set -g powersave --max=${max_freq}MHz >& /dev/null
 echo "Target      Actual      Difference     MSR(0x199)     max_perf_pct"
 for freq in `seq $max_freq -100 $min_freq`
 do
-	result_freq=$(cat /tmp/result.${freq} | grep "cpu MHz" | awk ' { print $4 } ' | awk -F "." ' { print $1 } ')
+       result_freq=$(cat /tmp/result.${freq} | grep "cpu MHz" \
        | awk '{print $4}' | awk -F "." '{print $1}')
+	result_freq=$(echo $result_freq | head -n1 | cut -d " " -f1)
 	msr=$(cat /tmp/result.${freq} | grep "msr" | awk ' { print $3 } ')
 	max_perf_pct=$(cat /tmp/result.${freq} | grep "max_perf_pct" | awk ' { print $2 } ' )
-	if [ $result_freq -eq $freq ]; then
+	if (( "$result_freq" == "$freq" ))
+	then
 		echo " $freq        $result_freq             0          $msr         $(($max_perf_pct*3300))"
 	else
 		echo " $freq        $result_freq          $(($result_freq-$freq))          $msr          $(($max_perf_pct*$max_freq))"
-- 
2.17.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-09 14:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-29 19:12 [PATCH] selftests:intel_pstate: fixes typical crash of a testing script for Intel P-State driver Jeffrin Jose T
2018-05-04 19:47 ` Shuah Khan
2018-05-08 20:21   ` Shuah Khan
2018-05-09 14:27     ` Jeffrin Thalakkottoor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).