LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sebastian Reichel <sre@kernel.org>,
Hans de Goede <hdegoede@redhat.com>, Jun Li <jun.li@nxp.com>
Cc: <linux-usb@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <support.opensource@diasemi.com>
Subject: [PATCH v6 3/6] power: supply: Add error checking of psy desc during registration
Date: Thu, 22 Mar 2018 15:52:04 +0000 [thread overview]
Message-ID: <f300edc1939335510a2d8f1302c49548915d89d0.1521732966.git.Adam.Thomson.Opensource@diasemi.com> (raw)
In-Reply-To: <cover.1521732966.git.Adam.Thomson.Opensource@diasemi.com>
Currently there's no error checking of this parameter in the
registration function and it's blindly added to psy class and
subsequently used as is. For example if this is NULL the call
to psy_register_thermal() will try to dereference the pointer
thus causing a kernel dump.
This commit updates the registration code to add some basic
checks on the desc pointer validity, name, and presence of
properties.
Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
---
drivers/power/supply/power_supply_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
index 82f998a..64f6449 100644
--- a/drivers/power/supply/power_supply_core.c
+++ b/drivers/power/supply/power_supply_core.c
@@ -849,6 +849,9 @@ static void psy_unregister_cooler(struct power_supply *psy)
pr_warn("%s: Expected proper parent device for '%s'\n",
__func__, desc->name);
+ if (!desc || !desc->name || !desc->properties || !desc->num_properties)
+ return ERR_PTR(-EINVAL);
+
psy = kzalloc(sizeof(*psy), GFP_KERNEL);
if (!psy)
return ERR_PTR(-ENOMEM);
--
1.9.1
next prev parent reply other threads:[~2018-03-22 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 15:52 [PATCH v6 0/6] typec: tcpm: Add sink side support for PPS Adam Thomson
2018-03-22 15:52 ` [PATCH v6 1/6] typec: tcpm: Add core support for sink side PPS Adam Thomson
2018-03-22 20:15 ` Guenter Roeck
2018-03-22 15:52 ` [PATCH v6 2/6] Documentation: power: Initial effort to document power_supply ABI Adam Thomson
2018-03-22 15:52 ` Adam Thomson [this message]
2018-03-22 15:52 ` [PATCH v6 4/6] power: supply: Add 'usb_type' property and supporting code Adam Thomson
2018-03-22 15:52 ` [PATCH v6 5/6] typec: tcpm: Represent source supply through power_supply Adam Thomson
2018-03-22 20:26 ` Guenter Roeck
2018-03-22 15:52 ` [PATCH v6 6/6] typec: tcpm: Add support for sink PPS related messages Adam Thomson
2018-03-22 20:32 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f300edc1939335510a2d8f1302c49548915d89d0.1521732966.git.Adam.Thomson.Opensource@diasemi.com \
--to=adam.thomson.opensource@diasemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sre@kernel.org \
--cc=support.opensource@diasemi.com \
--subject='Re: [PATCH v6 3/6] power: supply: Add error checking of psy desc during registration' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).