LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Rohit Kumar <rohitkr@codeaurora.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, andy.gross@linaro.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, robh+dt@kernel.org, bgoswami@codeaurora.org Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, rohkumar@qti.qualcomm.com, gregkh@linuxfoundation.org, plai@codeaurora.org, tiwai@suse.com, lgirdwood@gmail.com, david.brown@linaro.org, linux-arm-kernel@lists.infradead.org, spatakok@qti.qualcomm.com, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v7 16/24] ASoC: qdsp6: q6asm: Add support to audio stream apis Date: Fri, 4 May 2018 12:41:56 +0530 [thread overview] Message-ID: <f3b3d90b-6504-328e-c9f4-a3b3f085d9dc@codeaurora.org> (raw) In-Reply-To: <20180501120820.11016-17-srinivas.kandagatla@linaro.org> On 5/1/2018 5:38 PM, Srinivas Kandagatla wrote: > +static int __q6asm_run(struct audio_client *ac, uint32_t flags, > + uint32_t msw_ts, uint32_t lsw_ts, bool wait) > +{ > + struct asm_session_cmd_run_v2 *run; > + struct apr_pkt *pkt; > + int pkt_size, rc; > + void *p; > + > + pkt_size = APR_HDR_SIZE + sizeof(*run); > + p = kzalloc(pkt_size, GFP_KERNEL); Should be GFP_ATOMIC as this API is also called from interrupt context > + if (!p) > + return -ENOMEM; > + [..] > +int q6asm_read(struct audio_client *ac) > +{ > + struct asm_data_cmd_read_v2 *read; > + struct audio_port_data *port; > + struct audio_buffer *ab; > + struct apr_pkt *pkt; > + int pkt_size; > + int rc = 0; > + void *p; > + > + if (!(ac->io_mode & ASM_SYNC_IO_MODE)) > + return 0; > + > + pkt_size = APR_HDR_SIZE + sizeof(*read); > + p = kzalloc(pkt_size, GFP_KERNEL); same here. GFP_ATOMIC > + if (!p) > + return -ENOMEM; [..] > +int q6asm_write_async(struct audio_client *ac, uint32_t len, uint32_t msw_ts, > + uint32_t lsw_ts, uint32_t flags) > +{ > + struct asm_data_cmd_write_v2 *write; > + struct audio_port_data *port; > + struct audio_buffer *ab; > + struct apr_pkt *pkt; > + int pkt_size; > + int rc = 0; > + void *p; > + > + pkt_size = APR_HDR_SIZE + sizeof(*write); > + p = kzalloc(pkt_size, GFP_KERNEL); GFP_ATOMIC > + if (!p) > + return -ENOMEM; > Thanks, Rohit -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-05-04 7:11 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-01 12:07 [PATCH v7 00/24] ASoC: qcom: Add support to QDSP based Audio Srinivas Kandagatla 2018-05-01 12:07 ` [PATCH v7 01/24] soc: qcom dt-bindings: Add APR bus bindings Srinivas Kandagatla 2018-05-03 23:30 ` [alsa-devel] " Banajit Goswami 2018-05-04 17:33 ` Bjorn Andersson 2018-05-01 12:07 ` [PATCH v7 02/24] soc: qcom: Add APR bus driver Srinivas Kandagatla 2018-05-04 17:45 ` Bjorn Andersson 2018-05-11 3:18 ` Applied "soc: qcom: Add APR bus driver" to the asoc tree Mark Brown 2018-05-01 12:07 ` [PATCH v7 03/24] ASoC: qdsp6: dt-bindings: Add q6core dt bindings Srinivas Kandagatla 2018-05-03 23:45 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 04/24] ASoC: qdsp6: dt-bindings: Add q6afe " Srinivas Kandagatla 2018-05-01 12:37 ` Rob Herring 2018-05-03 23:50 ` Banajit Goswami 2018-05-11 3:17 ` Applied "ASoC: qdsp6: dt-bindings: Add q6afe dt bindings" to the asoc tree Mark Brown 2018-05-01 12:08 ` [PATCH v7 05/24] ASoC: qdsp6: dt-bindings: Add q6adm dt bindings Srinivas Kandagatla 2018-05-03 23:53 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 06/24] ASoC: qdsp6: dt-bindings: Add q6asm " Srinivas Kandagatla 2018-05-03 23:56 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 07/24] ASoC: qdsp6: q6common: Add qdsp6 helper functions Srinivas Kandagatla 2018-05-04 1:35 ` Banajit Goswami 2018-05-11 3:15 ` Applied "ASoC: qdsp6: q6common: Add qdsp6 helper functions" to the asoc tree Mark Brown 2018-05-01 12:08 ` [PATCH v7 08/24] ASoC: qdsp6: q6core: Add q6core driver Srinivas Kandagatla 2018-05-04 19:04 ` Banajit Goswami 2018-05-09 6:06 ` Srinivas Kandagatla 2018-05-01 12:08 ` [PATCH v7 09/24] ASoC: qdsp6: q6afe: Add q6afe driver Srinivas Kandagatla 2018-05-09 2:40 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 10/24] ASoC: qdsp6: qdafe: Add SLIMBus port Support Srinivas Kandagatla 2018-05-09 2:55 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 11/24] ASoC: qdsp6: q6afe: Add support to MI2S ports Srinivas Kandagatla 2018-05-09 3:21 ` Banajit Goswami 2018-05-09 6:05 ` Srinivas Kandagatla 2018-05-01 12:08 ` [PATCH v7 12/24] ASoC: qdsp6: q6afe: Add support to MI2S sysclks Srinivas Kandagatla 2018-05-09 4:29 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 13/24] ASoC: qdsp6: q6adm: Add q6adm driver Srinivas Kandagatla 2018-05-09 7:55 ` Banajit Goswami 2018-05-09 8:08 ` Srinivas Kandagatla 2018-05-01 12:08 ` [PATCH v7 14/24] ASoC: qdsp6: q6asm: Add q6asm driver Srinivas Kandagatla 2018-05-09 8:10 ` Banajit Goswami 2018-05-09 8:15 ` Srinivas Kandagatla 2018-05-01 12:08 ` [PATCH v7 15/24] ASoC: qdsp6: q6asm: Add support to memory map and unmap Srinivas Kandagatla 2018-05-09 8:23 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 16/24] ASoC: qdsp6: q6asm: Add support to audio stream apis Srinivas Kandagatla 2018-05-04 7:11 ` Rohit Kumar [this message] 2018-05-04 8:24 ` [alsa-devel] " Srinivas Kandagatla 2018-05-09 10:16 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 17/24] ASoC: qdsp6: q6routing: Add q6routing driver Srinivas Kandagatla 2018-05-09 8:56 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 18/24] ASoC: qdsp6: q6routing: Add support to all SLIMBus Mixers Srinivas Kandagatla 2018-05-09 8:39 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 19/24] ASoC: qdsp6: q6routing: Add support to MI2S Mixers Srinivas Kandagatla 2018-05-09 8:34 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 20/24] ASoC: qdsp6: q6afe: Add q6afe dai driver Srinivas Kandagatla 2018-05-09 9:42 ` Banajit Goswami 2018-05-09 9:43 ` Srinivas Kandagatla 2018-05-01 12:08 ` [PATCH v7 21/24] ASoC: qdsp6: q6asm: Add q6asm " Srinivas Kandagatla 2018-05-09 9:57 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 22/24] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings Srinivas Kandagatla 2018-05-09 9:01 ` Banajit Goswami 2018-05-01 12:08 ` [PATCH v7 23/24] ASoC: qcom: apq8096: Add db820c machine driver Srinivas Kandagatla 2018-05-09 9:15 ` Banajit Goswami 2018-05-09 10:03 ` Srinivas Kandagatla 2018-05-01 12:08 ` [PATCH v7 24/24] MAINTAINERS: Add myself as co-maintainer of qcom audio Srinivas Kandagatla 2018-05-09 9:16 ` Banajit Goswami
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f3b3d90b-6504-328e-c9f4-a3b3f085d9dc@codeaurora.org \ --to=rohitkr@codeaurora.org \ --cc=alsa-devel@alsa-project.org \ --cc=andy.gross@linaro.org \ --cc=bgoswami@codeaurora.org \ --cc=broonie@kernel.org \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=plai@codeaurora.org \ --cc=robh+dt@kernel.org \ --cc=rohkumar@qti.qualcomm.com \ --cc=spatakok@qti.qualcomm.com \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).