LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] pvcalls-front: fixes incorrect error handling
@ 2018-11-22  2:07 Pan Bian
  2018-11-26 20:31 ` [Xen-devel] " Boris Ostrovsky
  2018-11-29 16:54 ` Juergen Gross
  0 siblings, 2 replies; 9+ messages in thread
From: Pan Bian @ 2018-11-22  2:07 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini, xen-devel,
	linux-kernel

kfree() is incorrectly used to release the pages allocated by
__get_free_page() and __get_free_pages(). Use the matching deallocators
i.e., free_page() and free_pages(), respectively.

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 drivers/xen/pvcalls-front.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 2f11ca7..77224d8 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -385,8 +385,8 @@ static int create_active(struct sock_mapping *map, int *evtchn)
 out_error:
 	if (*evtchn >= 0)
 		xenbus_free_evtchn(pvcalls_front_dev, *evtchn);
-	kfree(map->active.data.in);
-	kfree(map->active.ring);
+	free_pages((unsigned long)map->active.data.in, PVCALLS_RING_ORDER);
+	free_page((unsigned long)map->active.ring);
 	return ret;
 }
 
-- 
2.7.4



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-11-29 16:54 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-22  2:07 [PATCH] pvcalls-front: fixes incorrect error handling Pan Bian
2018-11-26 20:31 ` [Xen-devel] " Boris Ostrovsky
2018-11-27  0:58   ` PanBian
2018-11-27 20:37     ` Stefano Stabellini
2018-11-27 20:57       ` Boris Ostrovsky
2018-11-27 21:08         ` Stefano Stabellini
2018-11-27 22:47           ` Boris Ostrovsky
2018-11-27 22:51             ` Stefano Stabellini
2018-11-29 16:54 ` Juergen Gross

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).