LKML Archive on
help / color / mirror / Atom feed
From: Dan Murphy <>
To: Andrew Lunn <>
Cc: <>, <>,
Subject: Re: [PATCH] net: phy: DP83811: Add support for the phy
Date: Tue, 8 May 2018 12:13:02 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


On 05/08/2018 11:49 AM, Andrew Lunn wrote:
> On Tue, May 08, 2018 at 10:56:55AM -0500, Dan Murphy wrote:
>> All
>> On 05/08/2018 09:11 AM, Dan Murphy wrote:
>>> Add support for the DP83811 phy by extending
>>> the DP83822 driver to recognize the PHY IDs.
>>> The DP83811 supports both rgmii and sgmii interfaces.
>>> There are 2 part numbers for this the DP83811R does not
>>> reliably support the SGMII interface but the DP83811S will.
>>> There is not a way to differentiate these parts from the
>>> hardware or register set.  So this is controlled via the DT
>>> to indicate which phy mode is required.  Or the part can be
>>> strapped to a certain interface.
>>> Data sheet can be found here:
>> I am withdrawing this patch for comment.
>> Some of the future features have varying register definitions between the DP83811
>> and DP83822
> Hi Dan
> It might be worth talking to the ASIC engineers and the
> test/qualification engineers. There are sometime undocumented
> registers for testing. You might be able to identify the exact device
> from these registers.

Thanks.  I talked to them prior to submitting this patch about determining which part is on the board.
I will ping them again and poke a little harder.

It turns out that we will probably need a new driver for this part anyway as there are
additional features that need to be supported that the 811 just does not support.

They want to support Master/Slave configurations.
The 822 supports fiber and eee while the 811 does not.
The 811 supports the IEEE802.3bw specific fields in MMD1 and MMD3, which are not in the 822.
The 811 does not support auto-negotiation on the MDI so all the auto-neg registers are invalid for the 811 but are valid for the 822.

Our Customer engineers felt that combining these two devices into a single driver may confuse the customer.


>      Andrew

Dan Murphy

  reply	other threads:[~2018-05-08 17:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 14:11 Dan Murphy
2018-05-08 15:56 ` Dan Murphy
2018-05-08 16:49   ` Andrew Lunn
2018-05-08 17:13     ` Dan Murphy [this message]
2018-05-08 17:14       ` Florian Fainelli
2018-05-08 17:21         ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] net: phy: DP83811: Add support for the phy' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).