LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Sebastian Reichel <sre@kernel.org>, David Heidelberg <david@ixit.cz>
Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, Thierry Reding <treding@nvidia.com>,
Rob Herring <robh+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mark Brown <broonie@kernel.org>,
Peter Chen <peter.chen@kernel.org>,
Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH v5 00/12] Add OTG mode support to Tegra USB PHY, SMB347 and Nexus 7
Date: Fri, 30 Jul 2021 21:30:27 +0300 [thread overview]
Message-ID: <f612e599-42ee-f385-b198-bdab95ab890a@gmail.com> (raw)
In-Reply-To: <ed3c2a5c-a916-2215-a767-5546fa8cd352@gmail.com>
30.07.2021 20:37, Dmitry Osipenko пишет:
> 17.07.2021 21:21, Dmitry Osipenko пишет:
> ...
>> power: supply: smb347-charger: Make smb347_set_writable() IRQ-safe
>> power: supply: smb347-charger: Utilize generic regmap caching
>> power: supply: smb347-charger: Implement USB VBUS regulator
>
> I noticed that charging doesn't work properly now, will fix it in v6.
>
For the record, it wasn't enough to enable the regmap caching, we also
need to fill up the cache on init by specifying the num_reg_defaults_raw
parameter.
This uncovered another problem where the pin control "enable" bit was
unsettling because the default regmap values were initialized to zeros
and driver doesn't set the enable bit at all.
prev parent reply other threads:[~2021-07-30 18:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 18:21 Dmitry Osipenko
2021-07-17 18:21 ` [PATCH v5 01/12] dt-bindings: phy: tegra20-usb-phy: Convert to schema Dmitry Osipenko
2021-07-17 18:21 ` [PATCH v5 02/12] dt-bindings: phy: tegra20-usb-phy: Document properties needed for OTG mode Dmitry Osipenko
2021-07-23 23:05 ` Rob Herring
2021-07-17 18:21 ` [PATCH v5 03/12] soc/tegra: pmc: Expose USB regmap to all SoCs Dmitry Osipenko
2021-07-17 18:21 ` [PATCH v5 04/12] usb: phy: tegra: Support OTG mode programming Dmitry Osipenko
2021-07-17 18:21 ` [PATCH v5 05/12] usb: otg-fsm: Fix hrtimer list corruption Dmitry Osipenko
2021-07-17 18:21 ` [PATCH v5 06/12] dt-bindings: power: supply: smb347-charger: Document USB VBUS regulator Dmitry Osipenko
2021-07-17 18:21 ` [PATCH v5 07/12] power: supply: smb347-charger: Make smb347_set_writable() IRQ-safe Dmitry Osipenko
2021-07-17 18:21 ` [PATCH v5 08/12] power: supply: smb347-charger: Utilize generic regmap caching Dmitry Osipenko
2021-07-17 18:21 ` [PATCH v5 09/12] power: supply: smb347-charger: Implement USB VBUS regulator Dmitry Osipenko
2021-07-17 18:21 ` [PATCH v5 10/12] ARM: tegra: Add new properties to USB PHY device-tree nodes Dmitry Osipenko
2021-07-17 18:21 ` [PATCH v5 11/12] ARM: tegra: nexus7: Enable USB OTG mode Dmitry Osipenko
2021-07-17 18:21 ` [PATCH v5 12/12] arm64: tegra132: Add new properties to USB PHY device-tree node Dmitry Osipenko
2021-07-30 17:37 ` [PATCH v5 00/12] Add OTG mode support to Tegra USB PHY, SMB347 and Nexus 7 Dmitry Osipenko
2021-07-30 18:30 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f612e599-42ee-f385-b198-bdab95ab890a@gmail.com \
--to=digetx@gmail.com \
--cc=balbi@kernel.org \
--cc=broonie@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=treding@nvidia.com \
--subject='Re: [PATCH v5 00/12] Add OTG mode support to Tegra USB PHY, SMB347 and Nexus 7' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).