From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753306AbdKWShT (ORCPT ); Thu, 23 Nov 2017 13:37:19 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:43816 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752948AbdKWShQ (ORCPT ); Thu, 23 Nov 2017 13:37:16 -0500 X-Google-Smtp-Source: AGs4zMZ1LK7LujYxNsEmgfQO7hLIM5er3IoehH5hpCeRbZLK1AVmpkd5T7N3+iSrvZyXt+bQgQFIYg== Subject: Re: [PATCH 2/8] mfd: mtk-mmsys: Add mmsys driver To: CK Hu Cc: ulrich.hecht+renesas@gmail.com, laurent.pinchart@ideasonboard.com, p.zabel@pengutronix.de, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, sboyd@codeaurora.org, lee.jones@linaro.org, davem@davemloft.net, gregkh@linuxfoundation.org, mchehab@kernel.org, rdunlap@infradead.org, pi-cheng.chen@linaro.org, sean.wang@mediatek.com, linux-clk@vger.kernel.org, linux@armlinux.org.uk, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger References: <20171114214114.15793-1-mbrugger@suse.com> <20171114214114.15793-3-mbrugger@suse.com> <1511427867.8489.9.camel@mtksdaap41> From: Matthias Brugger Message-ID: Date: Thu, 23 Nov 2017 19:37:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511427867.8489.9.camel@mtksdaap41> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/2017 10:04 AM, CK Hu wrote: >> +static const struct of_device_id of_match_mmsys[] = { >> + { .compatible = "mediatek,mt2701-mmsys", > > Because this driver replace the original "mediatek,mt2701-mmsys" driver, > could you modify the binding document of "mediatek,mt2701-mmsys" [1]? > > [1] > https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > Well we are actually no replacing the compatible but keeping it. But yes, the documentation should be updated. Apart right now we have the definition twice. The other location is here: Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt Regards, Matthias