LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: tangbin <tangbin@cmss.chinamobile.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: agross@kernel.org, sre@kernel.org, linux-arm-msm@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] power: supply: qcom_smbb: Remove superfluous errormessage
Date: Mon, 26 Jul 2021 09:16:15 +0800	[thread overview]
Message-ID: <f6a40fef-deac-e898-7cac-d9d246c84a24@cmss.chinamobile.com> (raw)
In-Reply-To: <YPbxS4KV+Fx01p7G@yoga>

Hi, Bjorn Andersson:

On 2021/7/20 23:52, Bjorn Andersson wrote:
> On Tue 20 Jul 09:15 CDT 2021, Tang Bin wrote:
>
>> In the probe function, when get irq failed, the function
>> platform_get_irq_byname() logs an error message, so remove
>> redundant message here.
>>
>> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> This says "Zhang certified this patch's origin, then you took the patch
> and you certified it's origin" - per Documentation/process/submitting-patches.rst
>
> But you, Tang, is the author or the patch, so how can Zhang have touched
> it before you wrote it?
>
> Perhaps you worked on it together? In which case you should include a
> Co-developed-by to indicate this.

I am sorry for the late reply to your email due to some reasons. The 
correct way to write it should be as follows:

     Co-developed-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>

     Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>

     Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

>
>
> Both commit message and patch looks good though!
>
whether should I send v2 for this patch?

Thanks

Tang Bin

>> ---
>>   drivers/power/supply/qcom_smbb.c | 5 +----
>>   1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c
>> index c890e1cec..84cc9fba0 100644
>> --- a/drivers/power/supply/qcom_smbb.c
>> +++ b/drivers/power/supply/qcom_smbb.c
>> @@ -929,11 +929,8 @@ static int smbb_charger_probe(struct platform_device *pdev)
>>   		int irq;
>>   
>>   		irq = platform_get_irq_byname(pdev, smbb_charger_irqs[i].name);
>> -		if (irq < 0) {
>> -			dev_err(&pdev->dev, "failed to get irq '%s'\n",
>> -				smbb_charger_irqs[i].name);
>> +		if (irq < 0)
>>   			return irq;
>> -		}
>>   
>>   		smbb_charger_irqs[i].handler(irq, chg);
>>   
>> -- 
>> 2.20.1.windows.1
>>
>>
>>



  reply	other threads:[~2021-07-26  1:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 14:15 [PATCH] power: supply: qcom_smbb: Remove superfluous error message Tang Bin
2021-07-20 15:52 ` Bjorn Andersson
2021-07-26  1:16   ` tangbin [this message]
2021-08-06 21:38     ` [PATCH] power: supply: qcom_smbb: Remove superfluous errormessage Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6a40fef-deac-e898-7cac-d9d246c84a24@cmss.chinamobile.com \
    --to=tangbin@cmss.chinamobile.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sre@kernel.org \
    --cc=zhangshengju@cmss.chinamobile.com \
    --subject='Re: [PATCH] power: supply: qcom_smbb: Remove superfluous errormessage' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).