LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>,
	robh+dt@kernel.org, mark.rutland@arm.com, pavel@ucw.cz,
	afd@ti.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH v5 2/2] leds: lm3601x: Introduce the lm3601x LED driver
Date: Mon, 14 May 2018 22:05:31 +0200	[thread overview]
Message-ID: <f7a98b66-977a-887c-d31a-ed908c9d1409@gmail.com> (raw)
In-Reply-To: <86c2bc2f-e622-9447-e4bb-b4ee37e2d44a@ti.com>

Hi Dan,

On 05/14/2018 09:40 PM, Dan Murphy wrote:
> Jacek
> 
> On 05/11/2018 06:56 AM, Dan Murphy wrote:
> <snip>
> 
>>>> +    }
>>>> +
>>>> +    if (led->strobe_node) {
>>>> +        ret = of_property_read_string(led->strobe_node, "label", &name);
>>>> +        if (!ret)
>>>> +            snprintf(led->strobe, sizeof(led->strobe),
>>>> +                "%s:%s", led->strobe_node->name, name);
>>>> +        else
>>>> +            snprintf(led->strobe, sizeof(led->strobe),
>>>> +                "%s::strobe", led->strobe_node->name);
>>>> +
>>>> +        ret = of_property_read_u32(led->strobe_node,
>>>> +                    "flash-max-microamp",
>>>> +                    &led->strobe_current_max);
>>>> +        if (ret < 0) {
>>>> +            led->strobe_current_max = LM3601X_MIN_STROBE_I_MA;
>>>> +            dev_warn(&led->client->dev,
>>>> +                 "flash-max-microamp DT property missing\n");
>>>> +        }
>>>> +
>>>> +        ret = of_property_read_u32(led->strobe_node,
>>>> +                    "flash-max-timeout-us",
>>>> +                    &led->max_strobe_timeout);
>>>> +        if (ret < 0) {
>>>> +            led->max_strobe_timeout = strobe_timeouts[0].reg_val;
>>>> +            dev_warn(&led->client->dev,
>>>> +                 "flash-max-timeout-us DT property missing\n");
>>>> +        }
>>>
>>> Common LED bindings state that flash-max-microamp and
>>> flash-max-timeout-us properties are mandatory.
>>
>> OK.
> 
> OK I looked at the max776973 driver and well if the flash-max-microamp and
> flash-max-timeout-us nodes are missing it sets a default value for each if the
> node is not present.

Ah, yes, this driver was being introduced as the first LED flash class 
driver and we were being iteratively adjusting LED common bindings
according to the new findings, so some details could have been left
out of sync.

> So should we remove this code from the Max77693 driver too and fail probe as being asked
> in this driver?

Yes, that would match what the bindings require.

-- 
Best regards,
Jacek Anaszewski

  parent reply	other threads:[~2018-05-14 20:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 17:47 [PATCH v5 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver Dan Murphy
2018-05-10 17:47 ` [PATCH v5 2/2] leds: lm3601x: Introduce the lm3601x LED driver Dan Murphy
2018-05-10 20:48   ` Jacek Anaszewski
2018-05-11 11:56     ` Dan Murphy
2018-05-11 20:26       ` Jacek Anaszewski
2018-05-14 19:40       ` Dan Murphy
2018-05-14 19:49         ` Andy Shevchenko
2018-05-14 20:05         ` Pavel Machek
2018-05-14 20:13           ` Dan Murphy
2018-05-14 20:16             ` Pavel Machek
2018-05-14 20:31               ` Dan Murphy
2018-05-14 20:05         ` Jacek Anaszewski [this message]
2018-05-14 20:09           ` Dan Murphy
2018-05-10 18:54 ` [PATCH v5 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver Pavel Machek
2018-05-10 19:06   ` Dan Murphy
2018-05-10 19:10     ` Dan Murphy
2018-05-10 20:17       ` Jacek Anaszewski
2018-05-11 12:12         ` Dan Murphy
2018-05-11 20:27           ` Jacek Anaszewski
2018-05-14 20:07             ` Dan Murphy
2018-05-14 20:48               ` Jacek Anaszewski
2018-05-10 20:50 ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7a98b66-977a-887c-d31a-ed908c9d1409@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v5 2/2] leds: lm3601x: Introduce the lm3601x LED driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).