LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@collabora.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Colin King <colin.king@canonical.com>
Subject: Re: Question on commit dc7109aaa233 ("futex: Validate waiter correctly in futex_proxy_trylock_atomic()")
Date: Wed, 1 Sep 2021 15:28:16 -0300	[thread overview]
Message-ID: <f9689421-a801-fd8d-b0bd-29280bebe78d@collabora.com> (raw)
In-Reply-To: <87a6kyfr4r.ffs@tglx>

Thomas,

Às 20:29 de 30/08/21, Thomas Gleixner escreveu:
> Lukas,
> 
> On Fri, Aug 20 2021 at 13:17, Lukas Bulwahn wrote:
>> Did you intend to return -EINVAL here? So:
>>
>> +       if (!top_waiter->rt_waiter || top_waiter->pi_state)
>> +               return -EINVAL;
> 
> Duh, yes.
> 
>> Static analysis tools are as foolish as they are... but every dog has its day...
> 
> IOW: Even a blind hen sometimes finds a grain of corn :)
> 
> Care to send a patch?
> 

A patch was already proposed with this fix:
https://lore.kernel.org/lkml/20210818131840.34262-1-colin.king@canonical.com/

  reply	other threads:[~2021-09-01 18:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 11:17 Lukas Bulwahn
2021-08-30 23:29 ` Thomas Gleixner
2021-09-01 18:28   ` André Almeida [this message]
2021-09-01 19:19     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9689421-a801-fd8d-b0bd-29280bebe78d@collabora.com \
    --to=andrealmeid@collabora.com \
    --cc=colin.king@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=tglx@linutronix.de \
    --subject='Re: Question on commit dc7109aaa233 ("futex: Validate waiter correctly in futex_proxy_trylock_atomic()")' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).