LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steven Price <steven.price@arm.com>
To: "Robin Murphy" <robin.murphy@arm.com>,
	"Rob Herring" <rob.e.herring@gmail.com>,
	"Clément Péron" <peron.clem@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 0/8] Allwinner H6 Mali GPU support
Date: Thu, 16 May 2019 14:21:35 +0100	[thread overview]
Message-ID: <fa434575-5576-aff5-8705-1f93eefa209c@arm.com> (raw)
In-Reply-To: <e8618889-9b22-7f9f-7451-3c08a80a0f9b@arm.com>

On 16/05/2019 12:19, Robin Murphy wrote:
[...]
> I was expecting to see a similar behaviour to my T620 (which I now
> assume was down to 64-bit job descriptors sort-of-but-not-quite working)
> but this does look a bit more fundamental - the fact that it's a level 1
> fault with VA == head == tail suggests to me that the MMU can't see the
> page tables at all to translate anything. I really hope that the H6 GPU
> integration doesn't suffer from the same DMA offset as the Allwinner
> display pipeline stuff, because that would be a real pain to support in
> io-pgtable.

Assuming you mean the case where the physical address (as seen by the
CPU) is different from the dma address (as seen by the GPU), then I
highly doubt it because mali_kbase doesn't support it:

[from kbase_mem_pool_alloc_page() in mali_kbase_mem_pool.c]:

	dma_addr = dma_map_page(dev, p, 0, PAGE_SIZE, DMA_BIDIRECTIONAL);
	if (dma_mapping_error(dev, dma_addr)) {
		__free_page(p);
		return NULL;
	}

	WARN_ON(dma_addr != page_to_phys(p));


That being said it's quite possible there could be something in the bus
which needs configuring to make this work - in which case your best bet
is to look at the vendor kernel and see if anything extra is poked when
the Mali driver is loaded.

Steve

  reply	other threads:[~2019-05-16 13:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-12 17:46 peron.clem
2019-05-12 17:46 ` [PATCH v4 1/8] dt-bindings: gpu: mali-midgard: Add resets property peron.clem
2019-05-12 17:46 ` [PATCH v4 2/8] dt-bindings: gpu: add bus clock for Mali Midgard GPUs peron.clem
2019-05-12 17:46 ` [PATCH v4 3/8] dt-bindings: gpu: mali-midgard: Add H6 mali gpu compatible peron.clem
2019-05-12 17:46 ` [PATCH v4 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6 peron.clem
2019-05-12 17:46 ` [PATCH v4 5/8] arm64: dts: allwinner: Add mali GPU supply for Pine H64 peron.clem
2019-05-12 18:28   ` [linux-sunxi] " Jagan Teki
2019-05-14 10:18     ` Chen-Yu Tsai
2019-05-14 15:22       ` Clément Péron
2019-05-12 17:46 ` [PATCH v4 6/8] arm64: dts: allwinner: Add mali GPU supply for Beelink GS1 peron.clem
2019-05-12 17:46 ` [PATCH v4 7/8] arm64: dts: allwinner: Add mali GPU supply for OrangePi Boards peron.clem
2019-05-12 17:46 ` [PATCH v4 8/8] arm64: dts: allwinner: Add mali GPU supply for OrangePi 3 peron.clem
2019-05-13 15:14 ` [PATCH v4 0/8] Allwinner H6 Mali GPU support Daniel Vetter
2019-05-14 10:29   ` Neil Armstrong
2019-05-14 15:17     ` Clément Péron
2019-05-14 21:22       ` Clément Péron
2019-05-14 21:56         ` Robin Murphy
2019-05-15 22:05           ` Clément Péron
2019-05-15 23:22             ` Rob Herring
2019-05-16 11:19               ` Robin Murphy
2019-05-16 13:21                 ` Steven Price [this message]
2019-05-25 19:50                 ` [linux-sunxi] " Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa434575-5576-aff5-8705-1f93eefa209c@arm.com \
    --to=steven.price@arm.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=narmstrong@baylibre.com \
    --cc=peron.clem@gmail.com \
    --cc=rob.e.herring@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=wens@csie.org \
    --subject='Re: [PATCH v4 0/8] Allwinner H6 Mali GPU support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).