LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Christina Quast <cquast@baylibre.com>,
	<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <narmstrong@baylibre.com>,
	Oleg Kokorin <ole2mail@mail.com>
Subject: Re: [PATCH 1/2] ARM: dts: am335x: Replace numeric pinmux address with macro defines
Date: Thu, 3 May 2018 13:25:39 -0500	[thread overview]
Message-ID: <fb4c48e1-f3fb-9e37-e945-15af1800ae3c@ti.com> (raw)
In-Reply-To: <20180503161916.GS98604@atomide.com>



On 05/03/2018 11:19 AM, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [180503 15:54]:
>>
>>
>> On 04/30/2018 12:31 PM, Tony Lindgren wrote:
>>> Hi,
>>>
>>> * Christina Quast <cquast@baylibre.com> [180430 11:23]:
>>>> The values are extraced from the "AM335x SitaraTM Processors Technical
>>>> Reference Manual", Section 9.3.1 CONTROL_MODULE Registers, based on the
>>>> file autogenerated by TI PinMux.
>>>
>>> This certainly makes things easier to mux :)
>>>
>>> Have you verified that the registers are the same across all am335x
>>> models and different revisions?
>>>
>>> It used to be that different SoC revisions could have different
>>> amount of registers and also different options in some cases.
>>>
>>>> +#define AM335X_CONTROL_REVISION			0x0
>>>> +#define AM335X_CONTROL_HWINFO			0x4
>>>> +#define AM335X_CONTROL_SYSCONFIG		0x10
>>>> +#define AM335X_CONTROL_STATUS			0x40
>>>
>>> You should only list the padconf mux registers here, no need to
>>> list any of the controller registers.
>>>
>>
>> To be honest, I do think it's right thing to do - DT by itself is
>> documentation and previously DT maintainers were not very happy regarding
>> introducing more defines instead of const.
> 
> Sounds like you mean "I don't think" above instead of "I do think"?
> Care to clarify..

i don't.. sry

> 
>> Adding such defines will introduce big headers in Linux common or
>> platform folders again which we've just got rid of.
>>
>> If smth is unclear - comments can be used in DT.
>>
>> Just my 5c.
> 
> The problem earlier was that we had just too many variants as
> the padconf registers got changed even between SoC revisions.
> Not always and not for many registers but still. The padconf
> register range seems to stay the same for a SoC though.
> 
> I do see value at being able to mux the registers easier though.



-- 
regards,
-grygorii

  reply	other threads:[~2018-05-03 18:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 11:20 [PATCH 0/2] Add macro defines for AM335x Christina Quast
2018-04-30 11:20 ` [PATCH 1/2] ARM: dts: am335x: Replace numeric pinmux address with macro defines Christina Quast
2018-04-30 17:31   ` Tony Lindgren
2018-05-03 15:52     ` Grygorii Strashko
2018-05-03 16:19       ` Tony Lindgren
2018-05-03 18:25         ` Grygorii Strashko [this message]
2018-04-30 11:20 ` [PATCH 2/2] ARM: dts: am335x: Replaced register offsets with defines Christina Quast
2019-03-13 14:27 [PATCH 0/2] ARM: dts: am335x: Replace numeric pinmux address with macro defines Christina Quast
2019-03-13 14:27 ` [PATCH 1/2] " Christina Quast
2019-03-14 14:59   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb4c48e1-f3fb-9e37-e945-15af1800ae3c@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=cquast@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=ole2mail@mail.com \
    --cc=tony@atomide.com \
    --subject='Re: [PATCH 1/2] ARM: dts: am335x: Replace numeric pinmux address with macro defines' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).