LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>
To: Dave Airlie <airlied@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
David Airlie <airlied@linux.ie>
Cc: virtualization@lists.linux-foundation.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: [PATCH 6/6] drm/qxl: Use 'unsigned int' instead of 'bool'
Date: Fri, 26 Oct 2018 16:24:58 -0300 [thread overview]
Message-ID: <fcd9d7ea7eec1ac6a3ad9ad16e0fc9ef13c089fd.1540579956.git.shayenneluzmoura@gmail.com> (raw)
In-Reply-To: <cover.1540579956.git.shayenneluzmoura@gmail.com>
Use 'unsigned int' with bitfield instead of 'bool' to avoid alignment
issues and remove checkpatch.pl check:
CHECK: Avoid using bool structure members because of possible alignment
issues
Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>
---
drivers/gpu/drm/qxl/qxl_drv.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index d78bcb95df3e..14d3fa855708 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.h
+++ b/drivers/gpu/drm/qxl/qxl_drv.h
@@ -88,10 +88,10 @@ struct qxl_bo {
/* Constant after initialization */
struct drm_gem_object gem_base;
- bool is_primary; /* is this now a primary surface */
- bool is_dumb;
+ unsigned int is_primary:1; /* is this now a primary surface */
+ unsigned int is_dumb:1;
struct qxl_bo *shadow;
- bool hw_surf_alloc;
+ unsigned int hw_surf_alloc:1;
struct qxl_surface surf;
uint32_t surface_id;
struct qxl_release *surf_create;
@@ -128,7 +128,7 @@ struct qxl_output {
struct qxl_mman {
struct ttm_bo_global_ref bo_global_ref;
struct drm_global_reference mem_global_ref;
- bool mem_global_referenced;
+ unsigned int mem_global_referenced:1;
struct ttm_bo_device bdev;
};
@@ -229,7 +229,7 @@ struct qxl_device {
struct qxl_ram_header *ram_header;
- bool primary_created;
+ unsigned int primary_created:1;
struct qxl_memslot *mem_slots;
uint8_t n_mem_slots;
--
2.19.1
next prev parent reply other threads:[~2018-10-26 19:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 19:20 [PATCH 0/6] drm/qxl: Remove checkpatch issues Shayenne da Luz Moura
2018-10-26 19:21 ` [PATCH 1/6] drm/qxl: Remove trailing whitespace Shayenne da Luz Moura
2018-10-26 19:22 ` [PATCH 2/6] drm/qxl: Add line after variable declarations Shayenne da Luz Moura
2018-10-26 19:23 ` [PATCH 3/6] drm/qxl: Remove exceding whiteline Shayenne da Luz Moura
2018-10-26 19:23 ` [PATCH 4/6] drm/qxl: Use 'unsigned int' instead of 'usigned' Shayenne da Luz Moura
2018-10-26 19:24 ` [PATCH 5/6] drm/qxl: Add space before open parentheses Shayenne da Luz Moura
2018-10-26 19:24 ` Shayenne da Luz Moura [this message]
2018-10-29 13:54 ` [Outreachy kernel] [PATCH 0/6] drm/qxl: Remove checkpatch issues Daniel Vetter
2018-10-30 6:15 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcd9d7ea7eec1ac6a3ad9ad16e0fc9ef13c089fd.1540579956.git.shayenneluzmoura@gmail.com \
--to=shayenneluzmoura@gmail.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=virtualization@lists.linux-foundation.org \
--subject='Re: [PATCH 6/6] drm/qxl: Use '\''unsigned int'\'' instead of '\''bool'\''' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).