LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Niklas Cassel <Niklas.Cassel@wdc.com>, Jens Axboe <axboe@kernel.dk>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
	Paolo Valente <paolo.valente@linaro.org>,
	Ming Lei <ming.lei@redhat.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] Revert "mq-deadline: Fix request accounting"
Date: Tue, 7 Sep 2021 08:15:03 -0700	[thread overview]
Message-ID: <fdd5ab2a-af90-69bd-2d37-c5060ce68de4@acm.org> (raw)
In-Reply-To: <20210907142145.112096-3-Niklas.Cassel@wdc.com>

On 9/7/21 7:21 AM, Niklas Cassel wrote:
> blk-mq will no longer call the I/O scheduler .finish_request() callback
> for requests that were never inserted to the I/O scheduler.

I do not agree. Even with patch 1/2 from this series applied, finish_request()
will still be called for requests inserted by blk_insert_cloned_request()
although these requests are never inserted to the I/O scheduler.

Bart.

  parent reply	other threads:[~2021-09-07 15:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 14:21 [PATCH 0/2] don't call io scheduler callbacks for passthrough requests Niklas Cassel
2021-09-07 14:21 ` [PATCH 1/2] blk-mq: don't call callbacks for requests that bypassed the scheduler Niklas Cassel
2021-09-07 14:29   ` Ming Lei
2021-09-07 14:21 ` [PATCH 2/2] Revert "mq-deadline: Fix request accounting" Niklas Cassel
2021-09-07 14:54   ` Bart Van Assche
2021-09-07 16:07     ` Niklas Cassel
2021-09-07 16:49       ` Bart Van Assche
2021-09-07 15:15   ` Bart Van Assche [this message]
2021-09-07 16:28     ` Niklas Cassel
2021-09-07 17:12       ` Bart Van Assche
2021-09-08 11:57         ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdd5ab2a-af90-69bd-2d37-c5060ce68de4@acm.org \
    --to=bvanassche@acm.org \
    --cc=Damien.LeMoal@wdc.com \
    --cc=Niklas.Cassel@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=paolo.valente@linaro.org \
    --subject='Re: [PATCH 2/2] Revert "mq-deadline: Fix request accounting"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).