LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc
@ 2018-05-02 14:43 Colin King
2018-05-02 15:04 ` Harry Wentland
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-05-02 14:43 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Zhou, David Airlie,
Harry Wentland, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The declaration of pointer amdgpu_crtc has a redundant assignment to
amdgpu_crtc. Clean this up by removing it.
Detected by CoverityScan, CID#1460299 ("Evaluation order violation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 1dd1142246c2..2beb8821e19e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -3773,7 +3773,7 @@ static void remove_stream(struct amdgpu_device *adev,
static int get_cursor_position(struct drm_plane *plane, struct drm_crtc *crtc,
struct dc_cursor_position *position)
{
- struct amdgpu_crtc *amdgpu_crtc = amdgpu_crtc = to_amdgpu_crtc(crtc);
+ struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
int x, y;
int xorigin = 0, yorigin = 0;
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc
2018-05-02 14:43 [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc Colin King
@ 2018-05-02 15:04 ` Harry Wentland
2018-05-09 19:50 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Harry Wentland @ 2018-05-02 15:04 UTC (permalink / raw)
To: Colin King, Alex Deucher, Christian König, David Zhou,
David Airlie, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
On 2018-05-02 10:43 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The declaration of pointer amdgpu_crtc has a redundant assignment to
> amdgpu_crtc. Clean this up by removing it.
>
> Detected by CoverityScan, CID#1460299 ("Evaluation order violation")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks like i goofed. Thanks for fixing this.
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 1dd1142246c2..2beb8821e19e 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -3773,7 +3773,7 @@ static void remove_stream(struct amdgpu_device *adev,
> static int get_cursor_position(struct drm_plane *plane, struct drm_crtc *crtc,
> struct dc_cursor_position *position)
> {
> - struct amdgpu_crtc *amdgpu_crtc = amdgpu_crtc = to_amdgpu_crtc(crtc);
> + struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
> int x, y;
> int xorigin = 0, yorigin = 0;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc
2018-05-02 15:04 ` Harry Wentland
@ 2018-05-09 19:50 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2018-05-09 19:50 UTC (permalink / raw)
To: Harry Wentland
Cc: Colin King, Alex Deucher, Christian König, David Zhou,
David Airlie, amd-gfx list, Maling list - DRI developers,
kernel-janitors, LKML
On Wed, May 2, 2018 at 11:04 AM, Harry Wentland <harry.wentland@amd.com> wrote:
> On 2018-05-02 10:43 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The declaration of pointer amdgpu_crtc has a redundant assignment to
>> amdgpu_crtc. Clean this up by removing it.
>>
>> Detected by CoverityScan, CID#1460299 ("Evaluation order violation")
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Looks like i goofed. Thanks for fixing this.
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Applied. Thanks!
Alex
>
> Harry
>
>> ---
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index 1dd1142246c2..2beb8821e19e 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -3773,7 +3773,7 @@ static void remove_stream(struct amdgpu_device *adev,
>> static int get_cursor_position(struct drm_plane *plane, struct drm_crtc *crtc,
>> struct dc_cursor_position *position)
>> {
>> - struct amdgpu_crtc *amdgpu_crtc = amdgpu_crtc = to_amdgpu_crtc(crtc);
>> + struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
>> int x, y;
>> int xorigin = 0, yorigin = 0;
>>
>>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-09 19:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 14:43 [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc Colin King
2018-05-02 15:04 ` Harry Wentland
2018-05-09 19:50 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).