LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Andi Kleen <ak@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: Linux 2.4.10-pre11 -- __builtin_expect
Date: 18 Sep 2001 13:13:48 +0200 [thread overview]
Message-ID: <jeelp4rbtf.fsf@sykes.suse.de> (raw)
In-Reply-To: <20010918031813.57E1062ABC@oscar.casa.dyndns.org.suse.lists.linux.kernel> <E15jBLy-0008UF-00@the-village.bc.nu.suse.lists.linux.kernel> <9o6j9l$461$1@cesium.transmeta.com.suse.lists.linux.kernel> <oup4rq0bwww.fsf_-_@pigdrop.muc.suse.de>
In-Reply-To: <oup4rq0bwww.fsf_-_@pigdrop.muc.suse.de> (Andi Kleen's message of "18 Sep 2001 12:44:47 +0200")
Andi Kleen <ak@suse.de> writes:
|> +#define likely(x) __builtin_expect((x), !0)
IMHO, this should better be written as
#define likely(x) __builtin_expect(!!(x), 1)
because x is not required to be pure boolean, so any nonzero value of x is
as likely as 1.
Andreas.
--
Andreas Schwab "And now for something
Andreas.Schwab@suse.de completely different."
SuSE Labs, SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
next prev parent reply other threads:[~2001-09-18 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20010918031813.57E1062ABC@oscar.casa.dyndns.org.suse.lists.linux.kernel>
[not found] ` <E15jBLy-0008UF-00@the-village.bc.nu.suse.lists.linux.kernel>
[not found] ` <9o6j9l$461$1@cesium.transmeta.com.suse.lists.linux.kernel>
2001-09-18 10:44 ` Andi Kleen
2001-09-18 11:13 ` Andreas Schwab [this message]
2001-09-18 12:38 ` Andi Kleen
2001-09-26 23:54 ` James Antill
2001-09-27 12:51 ` Andreas Schwab
2001-09-27 15:41 ` James Antill
2001-09-27 16:28 ` Andreas Schwab
2001-10-04 18:52 ` Richard Henderson
2001-10-08 6:17 ` James Antill
2001-09-18 20:11 ` Horst von Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeelp4rbtf.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=ak@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--subject='Re: Linux 2.4.10-pre11 -- __builtin_expect' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).