LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Tino Keitel <tino.keitel@gmx.de>, <linux-kernel@vger.kernel.org>,
	ath5k-devel@lists.ath5k.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-wireless@vger.kernel.org
Subject: Re: [RFT 1/1] single_chip test
Date: Wed, 06 Feb 2008 11:48:06 +0100	[thread overview]
Message-ID: <jezluetl7d.fsf@sykes.suse.de> (raw)
In-Reply-To: <1202294560-7313-1-git-send-email-jirislaby@gmail.com> (Jiri Slaby's message of "Wed\, 6 Feb 2008 11\:42\:40 +0100")

Jiri Slaby <jirislaby@gmail.com> writes:

> @@ -210,12 +205,16 @@ struct ath5k_hw *ath5k_hw_attach(struct ath5k_softc *sc, u8 mac_version)
>  	}
>  
>  	/* Identify single chip solutions */
> -	if((srev <= AR5K_SREV_VER_AR5414) &&
> -	(srev >= AR5K_SREV_VER_AR2424)) {
> -		ah->ah_single_chip = true;
> -	} else {
> -		ah->ah_single_chip = false;
> -	}
> +	ah->ah_single_chip = !!(srev >= AR5K_SREV_VER_AR2424 &&
                             ^^

This is useless.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  reply	other threads:[~2008-02-06 10:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 22:57 ath5k failure with 2.6.24-git14 Tino Keitel
2008-02-06  9:41 ` Andrew Morton
2008-02-06 10:42   ` [RFT 1/1] single_chip test Jiri Slaby
2008-02-06 10:48     ` Andreas Schwab [this message]
2008-02-06 10:53       ` Jiri Slaby
2008-02-06 15:00     ` Joseph Fannin
2008-02-06 15:46       ` Bob Copeland
2008-02-07 21:25         ` Tino Keitel
2008-02-07 21:51           ` Jiri Slaby
2008-02-08  7:28             ` Tino Keitel
2008-02-06 15:37   ` ath5k failure with 2.6.24-git14 Bob Copeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jezluetl7d.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tino.keitel@gmx.de \
    --subject='Re: [RFT 1/1] single_chip test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).