LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman) To: Andrew Morton <akpm@linux-foundation.org> Cc: <linux-kernel@vger.kernel.org>, Alexey Dobriyan <adobriyan@gmail.com>, Al Viro <viro@ZenIV.linux.org.uk>, Linux Containers <containers@lists.osdl.org> Subject: [PATCH 3/7] proc: Support multiple filesystems using the proc generic infrastructure Date: Thu, 06 Nov 2008 02:49:58 -0800 [thread overview] Message-ID: <m163n12ko9.fsf_-_@frodo.ebiederm.org> (raw) In-Reply-To: <m1abcd2kqk.fsf@frodo.ebiederm.org> (Eric W. Biederman's message of "Thu, 06 Nov 2008 02:48:35 -0800") - Implement proc_create_root to create a generic root directory. - Factor out release_proc_entry so that we can free a generic root directory. - Remove static from proc_sops so that we can access it in other files implementing a proc generic filesystem. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> --- fs/proc/generic.c | 30 +++++++++++++++++++++++++++--- fs/proc/inode.c | 2 +- fs/proc/internal.h | 3 +++ 3 files changed, 31 insertions(+), 4 deletions(-) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 60a359b..8669cf6 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -532,7 +532,6 @@ static int proc_register(struct proc_dir_entry * dir, struct proc_dir_entry * dp dp->proc_fops = &proc_dir_operations; dp->proc_iops = &proc_dir_inode_operations; } - dir->nlink++; } else if (S_ISLNK(dp->mode)) { if (dp->proc_iops == NULL) dp->proc_iops = &proc_link_inode_operations; @@ -555,6 +554,8 @@ static int proc_register(struct proc_dir_entry * dir, struct proc_dir_entry * dp dp->next = dir->subdir; dp->parent = dir; dir->subdir = dp; + if (S_ISDIR(dp->mode)) + dir->nlink++; spin_unlock(&proc_subdir_lock); return 0; @@ -599,6 +600,24 @@ static struct proc_dir_entry *__proc_create(struct proc_dir_entry **parent, return ent; } +struct proc_dir_entry *proc_create_root(void) +{ + struct proc_dir_entry *ent, *parent = NULL; + + ent = __proc_create(&parent, "..", S_IFDIR | S_IRUGO | S_IXUGO, 2); + if (ent) { + ent->proc_fops = &proc_dir_operations; + ent->proc_iops = &proc_dir_inode_operations; + ent->low_ino = get_inode_number(); + ent->parent = ent; + if (!ent->low_ino) { + kfree(ent); + ent = NULL; + } + } + return ent; +} + struct proc_dir_entry *proc_symlink(const char *name, struct proc_dir_entry *parent, const char *dest) { @@ -758,6 +777,8 @@ void remove_proc_entry(const char *name, struct proc_dir_entry *parent) de = *p; *p = de->next; de->next = NULL; + if (S_ISDIR(de->mode)) + parent->nlink--; break; } } @@ -765,6 +786,11 @@ void remove_proc_entry(const char *name, struct proc_dir_entry *parent) if (!de) return; + release_proc_entry(de); +} + +void release_proc_entry(struct proc_dir_entry *de) +{ spin_lock(&de->pde_unload_lock); /* * Stop accepting new callers into module. If you're @@ -800,8 +826,6 @@ continue_removing: } spin_unlock(&de->pde_unload_lock); - if (S_ISDIR(de->mode)) - parent->nlink--; de->nlink = 0; WARN(de->subdir, KERN_WARNING "%s: removing non-empty directory " "'%s/%s', leaking at least '%s'\n", __func__, diff --git a/fs/proc/inode.c b/fs/proc/inode.c index 2543fd0..f3f81e2 100644 --- a/fs/proc/inode.c +++ b/fs/proc/inode.c @@ -115,7 +115,7 @@ void __init proc_init_inodecache(void) init_once); } -static const struct super_operations proc_sops = { +const struct super_operations proc_sops = { .alloc_inode = proc_alloc_inode, .destroy_inode = proc_destroy_inode, .drop_inode = generic_delete_inode, diff --git a/fs/proc/internal.h b/fs/proc/internal.h index 2a8eabb..6fe00ff 100644 --- a/fs/proc/internal.h +++ b/fs/proc/internal.h @@ -86,6 +86,9 @@ struct dentry *proc_lookup_de(struct proc_dir_entry *de, struct inode *ino, struct dentry *dentry); int proc_readdir_de(struct proc_dir_entry *de, struct file *filp, void *dirent, filldir_t filldir); +struct proc_dir_entry *proc_create_root(void); +void release_proc_entry(struct proc_dir_entry *de); +extern const struct super_operations proc_sops; struct pde_opener { struct inode *inode; -- 1.5.3.rc6.17.g1911
next prev parent reply other threads:[~2008-11-06 10:55 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-11-06 10:38 [PATCH 1/7] vfs: Fix shrink_submounts Eric W. Biederman 2008-11-06 10:48 ` [PATCH 2/7] proc: Implement support for automounts in task directories Eric W. Biederman 2008-11-06 10:49 ` Eric W. Biederman [this message] 2008-11-06 10:53 ` [PATCH 4/7] proc: Make /proc/net it's own filesystem Eric W. Biederman 2008-11-06 10:56 ` [PATCH 5/7] proc_net: Don't show the wrong /proc/net after unshare Eric W. Biederman 2008-11-06 10:57 ` [PATCH 6/7] proc_net: Simplify network namespace lookup Eric W. Biederman 2008-11-06 10:58 ` [PATCH 7/7] proc: Cleanup proc_flush_task Eric W. Biederman 2008-11-07 1:25 ` [PATCH 2/7] proc: Implement support for automounts in task directories Andrew Morton 2008-11-07 2:02 ` Eric W. Biederman 2008-11-07 1:26 ` Andrew Morton 2008-11-07 2:05 ` Eric W. Biederman 2008-11-07 2:49 ` Andrew Morton 2008-11-07 3:51 ` Eric W. Biederman 2008-11-07 4:28 ` Andrew Morton 2008-11-07 15:51 ` Eric W. Biederman 2008-11-07 16:05 ` Andrew Morton 2008-11-07 16:58 ` Eric W. Biederman 2008-11-13 23:39 ` Eric W. Biederman 2008-11-19 0:07 ` Alexey Dobriyan 2008-11-19 2:35 ` Alexey Dobriyan 2008-11-19 13:20 ` Eric W. Biederman 2008-11-07 4:41 ` Alexey Dobriyan 2008-11-07 16:04 ` [PATCH] proc: Supply proc_shrink_automounts when CONFIG_PROC_FS=N Eric W. Biederman 2008-11-07 1:22 ` [PATCH 1/7] vfs: Fix shrink_submounts Andrew Morton 2008-11-07 2:06 ` Eric W. Biederman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=m163n12ko9.fsf_-_@frodo.ebiederm.org \ --to=ebiederm@xmission.com \ --cc=adobriyan@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=containers@lists.osdl.org \ --cc=linux-kernel@vger.kernel.org \ --cc=viro@ZenIV.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).