LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: MSI entry unlinked before arch_teardown_msi_irq().
Date: Sun, 25 Feb 2007 02:08:07 -0700	[thread overview]
Message-ID: <m17iu6r4eg.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070224.235020.92583817.davem@davemloft.net> (David Miller's message of "Sat, 24 Feb 2007 23:50:20 -0800 (PST)")


David Miller <davem@davemloft.net> writes:

> ric, you recommended to me that I use:
>
> 	struct msi_desc *entry = get_irq_data(irq);
>
> in my arch_teardown_msi_irq() routine earlier, but the current
> code unlinks the entry before the call to arch_teardown_msi_irq()
> so I get OOPS's on shutdown on sparc64 because of this since
> get_irq_data() will return NULL at that point.
>
> Can you fix this up or suggest how I should code the patch to
> your liking so I can take care of it?

I'm guessing my patch to switch the appropriate from get_irq_data to
get_irq_msi was merged in between that conversation and this.

Sorry about that. 

There was a real problem that ppc used the data stored in get_irq_data
for something else.  So we added a dedicated pointer to struct irq_desc.

If that isn't the issue holler and I will look into it a little more.

Eric

  reply	other threads:[~2007-02-25  9:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-25  7:50 David Miller
2007-02-25  9:08 ` Eric W. Biederman [this message]
2007-02-25 23:46   ` David Miller
2007-02-26  0:14     ` Eric W. Biederman
2007-02-26  2:03       ` David Miller
2007-02-26  5:51         ` Eric W. Biederman
2007-02-26 17:47       ` David Miller
2007-02-26 22:29         ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m17iu6r4eg.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: MSI entry unlinked before arch_teardown_msi_irq().' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).