LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: email@example.com (Eric W. Biederman)
To: "Serge E. Hallyn" <firstname.lastname@example.org>
Cc: Benjamin Thery <email@example.com>,
Dave Miller <firstname.lastname@example.org>,
Greg Kroah-Hartman <email@example.com>,
Al Viro <firstname.lastname@example.org>,
Daniel Lezcano <email@example.com>,
firstname.lastname@example.org, Tejun Heo <email@example.com>,
Denis Lunev <firstname.lastname@example.org>,
Linux Containers <email@example.com>
Subject: Re: [PATCH 0/4][RFC] netns: sysfs: add a netns suffix to net device sysfs entries
Date: Wed, 22 Oct 2008 14:01:59 -0700 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
In-Reply-To: <20081022203045.GA4633@us.ibm.com> (Serge E. Hallyn's message of "Wed, 22 Oct 2008 15:30:45 -0500")
"Serge E. Hallyn" <email@example.com> writes:
> Quoting Eric W. Biederman (firstname.lastname@example.org):
>> Benjamin Thery <email@example.com> writes:
>> > Support for network namespaces in mainline is pretty complete for
>> > some time now, but there is still this issue with sysfs that prevents
>> > more people to use it easily.
>> Ben your patchset is completely inappropriate.
>> Temporarily adding elements to the ABI that we intend to remove
>> is not a proper solution to this problem.
>> That user space visible ida you add is a namespace identifier that breaks
>> nested containers and migration. It is very very very wrong.
> I disagree (not surprising :) completely. The well-known userspace
> tools (ifconfig, ip, etc) will not see the lo@1, they'll see lo.
> Userspace in a container can either umount /sys completely, or do
The well-known user space tools don't use /sys at all. Modern
network tools use rtnetlink (ip) old network tools use /proc/net.
Very few things actually use /sys and for those things lo@1 or
eth0@1 are completely useless except for implementing a FUSE
mock up of sysfs. But you don't need anything in sysfs to do
that as all of the interesting information is available through
/proc/net or rtnetlink.
> mount -t tmpfs none /sys/class/net
> mount --bind /sys/devices/virtual/net/lo@1 /sys/class/net/lo
> if they really want to, in which case only their view
> of /sys/devices/virtual/net would be different.
> Eric, would you hate this less if it was under some
> config variable?
No. ABI decisions are almost certainly irreversible.
If we need an immediate hack please see the patch I sent
in follow up. We can achieve everything Ben is doing by simply
keeping virtual devices out of the kobject tree. Keeping them
from showing up in sysfs.
next prev parent reply other threads:[~2008-10-22 21:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 15:21 Benjamin Thery
2008-10-22 15:21 ` [PATCH 1/4] netns: add in ida ID to identify the network namespace Benjamin Thery
2008-10-22 15:22 ` [PATCH 2/4] netns: Export nets id to /proc/net/netns Benjamin Thery
2008-10-22 15:22 ` [PATCH 3/4] net: cleanup some vars names to be more consistant with the network code Benjamin Thery
2008-10-22 15:22 ` [PATCH 4/4] netns: sysfs: add netns suffix to net devices sysfs entries Benjamin Thery
2008-10-22 19:59 ` [PATCH 0/4][RFC] netns: sysfs: add a netns suffix to net device " Eric W. Biederman
2008-10-22 20:30 ` Serge E. Hallyn
2008-10-22 21:01 ` Eric W. Biederman [this message]
2008-10-22 21:55 ` Stephen Hemminger
2008-10-22 22:54 ` Eric W. Biederman
2008-10-23 4:14 ` Kyle Moffett
2008-10-23 11:56 ` Benjamin Thery
2008-10-23 15:46 ` Eric W. Biederman
2008-10-22 20:16 ` Greg KH
2008-10-22 21:08 ` Eric W. Biederman
2008-10-22 21:24 ` Greg KH
2008-10-22 20:32 ` [PATCH] netns: Coexist with the sysfs limitations Eric W. Biederman
2008-10-22 20:40 ` Daniel Lezcano
2008-10-22 21:21 ` Serge E. Hallyn
2008-10-23 8:04 ` Benjamin Thery
2008-10-23 15:40 ` Eric W. Biederman
2008-10-23 15:56 ` [PATCH] netns: Coexist with the sysfs limitations v2 Eric W. Biederman
2008-10-27 19:41 ` David Miller
2008-10-27 20:19 ` Eric W. Biederman
2008-10-28 0:50 ` David Miller
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH 0/4][RFC] netns: sysfs: add a netns suffix to net device sysfs entries' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).