LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: jengelh@linux01.gwdg.de, akpm@linux-foundation.org,
serue@us.ibm.com, viro@ftp.linux.org.uk, linuxram@us.ibm.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
containers@lists.osdl.org, hpa@zytor.com
Subject: Re: [patch] unprivileged mounts update
Date: Thu, 26 Apr 2007 22:10:31 -0600 [thread overview]
Message-ID: <m1abwujw3s.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <E1HhAYu-000361-00@dorka.pomaz.szeredi.hu> (Miklos Szeredi's message of "Thu, 26 Apr 2007 22:27:32 +0200")
Miklos Szeredi <miklos@szeredi.hu> writes:
>> On Apr 25 2007 11:21, Eric W. Biederman wrote:
>> >>
>> >> Why did we want to use fsuid, exactly?
>> >
>> >- Because ruid is completely the wrong thing we want mounts owned
>> > by whomever's permissions we are using to perform the mount.
>>
>> Think nfs. I access some nfs file as an unprivileged user. knfsd, by
>> nature, would run as euid=0, uid=0, but it needs fsuid=jengelh for
>> most permission logic to work as expected.
>
> I don't think knfsd will ever want to call mount(2).
>
> But yeah, I've been convinced, that using fsuid is the right thing to
> do.
Actually knfsd does call mount when it crosses a mount point on the nfs
server it generates an equivalent mount point in linux. At least I think
that is the what it is doing. It is very similar to our mount propagation
path.
However as a special case I don't think the permission checking is likely
to bite us there. It is worth double checking once we have the other details
ironed out.
Eric
next prev parent reply other threads:[~2007-04-27 4:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 7:45 Miklos Szeredi
2007-04-25 15:18 ` Miklos Szeredi
2007-04-25 16:55 ` H. Peter Anvin
2007-04-25 17:20 ` Serge E. Hallyn
2007-04-25 17:46 ` Eric W. Biederman
2007-04-25 17:56 ` Serge E. Hallyn
2007-04-25 18:41 ` Eric W. Biederman
2007-04-25 18:52 ` Serge E. Hallyn
2007-04-25 19:33 ` Miklos Szeredi
2007-04-26 14:57 ` Serge E. Hallyn
2007-04-26 15:23 ` Miklos Szeredi
2007-04-26 16:19 ` Serge E. Hallyn
2007-04-26 16:29 ` Miklos Szeredi
2007-04-26 19:42 ` Serge E. Hallyn
2007-04-26 19:56 ` Miklos Szeredi
2007-04-27 2:10 ` Serge E. Hallyn
2007-04-25 17:21 ` Eric W. Biederman
2007-04-25 17:30 ` Serge E. Hallyn
2007-04-26 19:10 ` Jan Engelhardt
2007-04-26 20:27 ` Miklos Szeredi
2007-04-27 4:10 ` Eric W. Biederman [this message]
2007-04-27 7:01 ` Jan Engelhardt
2007-04-25 19:33 ` Andrew Morton
2007-04-25 19:45 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1abwujw3s.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=hpa@zytor.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=miklos@szeredi.hu \
--cc=serue@us.ibm.com \
--cc=viro@ftp.linux.org.uk \
--subject='Re: [patch] unprivileged mounts update' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).