LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
selinux@tycho.nsa.gov, jmorris@namei.org
Subject: Re: [PATCH] sysctl selinux: Don't look at table->de
Date: Mon, 29 Jan 2007 12:16:54 -0700 [thread overview]
Message-ID: <m1d54xk5i1.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <1170096231.8720.102.camel@moss-spartans.epoch.ncsc.mil> (Stephen Smalley's message of "Mon, 29 Jan 2007 13:43:51 -0500")
Stephen Smalley <sds@tycho.nsa.gov> writes:
>> > If the ctl_table supplied more information about the functional purpose
>> > and the security sensitivity of the sysctl, then we could leverage that
>> > information instead, as long as we can at least derive the current
>> > labelings from that information for compatibility.
>>
>> What do information do you need to do need? Do you need extra fields in
> sysctl?
>> I am more than willing to help but I am not familiar enough with selinux
>> to do a reasonable job on my own.
>
> At present, we map the sysctls into functional groups (e.g. net, vm,
> fs, ...) that parallel the sysctl hierarchy so that we can limit access
> to only those programs/processes that need access for their purpose, and
> further partition where it makes sense to do so. We also separate out
> particularly security sensitive ones like modprobe and hotplug. So if
> the ctl_table carried some indication of functional grouping and
> security relevance (for some relatively small number of equivalence
> classes), then we could map those to labels instead of the current
> scheme. And if we could have the ctl_table inherit the information from
> its logical "parent" in the hierarchy by default, then it shouldn't
> require too invasive a patch.
Ok. So basically what you need is a parent pointer or some other way
of getting the full sysctl_path. All of the names that show up in /proc
are still present in the ctl_table.
Hmm. In parse_table we actually call sysctl_perm at each path component,
I'm not doing that in proc_sysctl.c at the moment but that would be easy to
add.
I think I will look at adding the back pointers. Adding the security
check during lookup is nice but it won't really give you the context
you could use. There may be a point in adding a security check during
lookup as well, but I think the way the VFS works there are weird implications
there.
Eric
next prev parent reply other threads:[~2007-01-29 19:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200701280106.l0S16CG3019873@shell0.pdx.osdl.net>
[not found] ` <20070127172410.2b041952.akpm@osdl.org>
[not found] ` <1169972718.17469.164.camel@localhost.localdomain>
[not found] ` <20070128003549.2ca38dc8.akpm@osdl.org>
[not found] ` <20070128093358.GA2071@elte.hu>
[not found] ` <20070128095712.GA6485@elte.hu>
[not found] ` <20070128100627.GA8416@elte.hu>
[not found] ` <20070128104548.a835d859.akpm@osdl.org>
2007-01-28 19:21 ` Eric W. Biederman
2007-01-29 13:04 ` Stephen Smalley
2007-01-29 15:23 ` James Morris
2007-01-29 17:55 ` Eric W. Biederman
2007-01-29 19:26 ` Stephen Smalley
2007-01-29 17:43 ` Eric W. Biederman
2007-01-29 18:43 ` Stephen Smalley
2007-01-29 19:08 ` Casey Schaufler
2007-01-29 20:07 ` Stephen Smalley
2007-01-30 10:25 ` Christoph Hellwig
2007-01-30 17:19 ` Casey Schaufler
2007-01-29 19:16 ` Eric W. Biederman [this message]
2007-01-29 23:28 ` Russell Coker
2007-02-06 21:16 ` [PATCH 1/2] sysctl: Add a parent entry to ctl_table and set the parent entry Eric W. Biederman
2007-02-06 21:21 ` [PATCH 2/2] sysctl: Restore the selinux path based label lookup for sysctls Eric W. Biederman
2007-02-07 18:24 ` Stephen Smalley
2007-02-07 21:12 ` Stephen Smalley
2007-02-07 21:54 ` Stephen Smalley
2007-02-07 22:21 ` Eric W. Biederman
2007-02-08 15:07 ` Stephen Smalley
2007-02-08 1:57 ` Eric W. Biederman
2007-02-08 15:01 ` Stephen Smalley
2007-02-08 17:53 ` Eric W. Biederman
2007-02-08 18:13 ` Stephen Smalley
2007-02-08 22:17 ` Eric W. Biederman
2007-02-08 22:51 ` [PATCH 0/5] sysctl cleanup selinux fixes Eric W. Biederman
2007-02-08 22:53 ` [PATCH 1/5] sysctl: Remove declaration of nonexistent sysctl_init() Eric W. Biederman
2007-02-08 22:54 ` [PATCH 2/5] sysctl: Set the parent field in the root sysctl table Eric W. Biederman
2007-02-08 22:55 ` [PATCH 3/5] sysctl: Fix the selinux_sysctl_get_sid Eric W. Biederman
2007-02-08 23:02 ` [PATCH 4/5] selinux: Enhance selinux to always ignore private inodes Eric W. Biederman
2007-02-08 23:04 ` [PATCH 5/5] sysctl: Hide the sysctl proc inodes from selinux Eric W. Biederman
2007-02-09 12:26 ` [PATCH 4/5] selinux: Enhance selinux to always ignore private inodes Stephen Smalley
2007-02-09 12:24 ` [PATCH 3/5] sysctl: Fix the selinux_sysctl_get_sid Stephen Smalley
2007-02-09 11:05 ` [PATCH 0/5] sysctl cleanup selinux fixes Andrew Morton
2007-02-09 18:09 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1d54xk5i1.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=tglx@linutronix.de \
--subject='Re: [PATCH] sysctl selinux: Don'\''t look at table->de' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).