From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763525AbYCDWZz (ORCPT ); Tue, 4 Mar 2008 17:25:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757061AbYCDWZj (ORCPT ); Tue, 4 Mar 2008 17:25:39 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:38380 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754655AbYCDWZi (ORCPT ); Tue, 4 Mar 2008 17:25:38 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Pavel Emelyanov Cc: Andrew Morton , David Miller , Alexey Dobriyan , Linux Netdev List , Linux Kernel Mailing List Subject: Re: [PATCH 0/2] Fix /proc/net in presence of net namespaces References: <47C6D743.1050802@openvz.org> <47C7B779.808@openvz.org> <47CBBC61.1010605@openvz.org> Date: Tue, 04 Mar 2008 15:23:59 -0700 In-Reply-To: <47CBBC61.1010605@openvz.org> (Pavel Emelyanov's message of "Mon, 03 Mar 2008 11:52:49 +0300") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavel Emelyanov writes: >> >> It takes a little updating of how we use pids. The easiest method >> is to add an extra counter. So we know when someone besides the hash >> chains is using the pid as an id. However it might make sense to actually >> have a net namespace pointer in the pid. > > No, please, no. I'm strongly opposed to making pids provide identification > for anything we need in the kernel. I don't see the problem. Sessions and process groups are roughly the same kinds of concept as namespaces. However I do agree that not using any kind of id is cleaner, leaves us with less legacy that we have to deal with, and keeps struct pid small, so it is preferable. Eric