LKML Archive on
help / color / mirror / Atom feed
From: (Eric W. Biederman)
	Greg Kroah-Hartman <>,
	"David S. Miller" <>,
	Benjamin Herrenschmidt <>,, Andrew Morton <>,
Subject: Re: [PATCH 17/21] MSI: Clear the irq_desc's msi pointer on free
Date: Sun, 25 Mar 2007 21:07:31 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Michael Ellerman's message of "Mon, 26 Mar 2007 12:57:16 +1000")

Michael Ellerman <> writes:

> We don't call dynamic_irq_cleanup(), so it never gets done. Perhaps we
> should be using your dynamic_irq_init/cleanup.

It depends.  If you are going through another irq controller etc.
dynamic_irq_cleanup is probably excessive.

>> Therefore you are doing this too late and we need to ensure the
>> architecture code does this in arch_teardown_msi_irq.
> As long as the arch teardown routine somehow calls dynamic_irq_cleanup()
> it should be fine. But I guess it's probably safer to just have all
> archs do set_msi_irq(irq, NULL) in the teardown.

Yes.  That sounds correct.


      reply	other threads:[~2007-03-26  3:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2007-03-22 14:23 ` Eric W. Biederman
2007-03-22 23:01   ` Michael Ellerman
2007-03-23  3:00     ` Eric W. Biederman
2007-03-26  2:57       ` Michael Ellerman
2007-03-26  3:07         ` Eric W. Biederman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 17/21] MSI: Clear the irq_desc'\''s msi pointer on free' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).