LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linux-pci@atrey.karlin.mff.cuni.cz,
	Greg Kroah-Hartman <greg@kroah.com>,
	"David S. Miller" <davem@davemloft.net>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	<linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>,
	<daniel.e.wolstenholme@intel.com>
Subject: Re: [PATCH 0/21] MSI rework
Date: Thu, 22 Mar 2007 09:01:10 -0600	[thread overview]
Message-ID: <m1lkhp8gqx.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <1174560686.307511.956605711793.qpush@cradle> (Michael Ellerman's message of "Thu, 22 Mar 2007 21:51:26 +1100")

Michael Ellerman <michael@ellerman.id.au> writes:

> This is my series to rework the generic MSI code into something we can use
> on powerpc[1].
>
> I've tried as much as possible not to change the semantics for other archs,
> but there's a few little changes. I think they're all OK in their own right.
>
> I don't have any serious hardware to test on, but my little x86_64 box with
> an e1000 using MSI still works with these changes. I've also got MSI working
> on a powerpc blade with a tg3. I haven't tested MSI-X _at all_.
>
> I've also tested on the blade with a debug hack to make the MSI case
> allocate/free 8 MSIs, but only use the last one, just to exercise the n > 1
> case a little. All seems to work fine.

Generally I think this looks good.  However there is a lot here, and some
of it potentially at least has some pretty subtle side effects.

So reviewing all of these patches at once is almost certain to cause
something important to be missed :(

Can we slow this process down a few days by taking this one logical chunk
at a time?

i.e.  First the simple bug fixes that should purely be restructure of
msi.c with no affect on anything outside of it.

And then get into the architecture enhancements.

Eric

       reply	other threads:[~2007-03-22 15:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1174560686.307511.956605711793.qpush@cradle>
2007-03-22 15:01 ` Eric W. Biederman [this message]
2007-03-22 19:08   ` Greg KH
2007-03-22 22:02     ` Benjamin Herrenschmidt
2007-03-22 22:08       ` Greg KH
2007-03-22 22:31         ` Benjamin Herrenschmidt
2007-03-23  4:17         ` Michael Ellerman
2007-03-23 10:25           ` Eric W. Biederman
2007-03-26  7:09             ` Michael Ellerman
2007-03-26 11:52               ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1lkhp8gqx.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=daniel.e.wolstenholme@intel.com \
    --cc=davem@davemloft.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=michael@ellerman.id.au \
    --subject='Re: [PATCH 0/21] MSI rework' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).