LKML Archive on
help / color / mirror / Atom feed
From: (Eric W. Biederman)
Cc: Linus Torvalds <>,,,
	Greg Kroah-Hartman <>
Subject: Re: [PATCH 2/3] msi:  Fixup the msi enable/disable logic
Date: Tue, 06 Mar 2007 22:19:06 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Michael Ellerman's message of "Fri, 02 Mar 2007 11:26:48 +0900")

Michael Ellerman <> writes:

> Hi Eric, comments below ..
> I get the reasoning for disabling MSI before we start writing back the
> config space, but don't we want to re-enable MSI on the way out?

We are restoring the entire msi flags register which includes the enable bit,
setting it a second time is gratuitous.

In addition if we are restoring the register when the enable bit is not set.
(because we don't have a mask bit) enabling the msi state is actually
the wrong thing to do.    But I admit that case can only happen after
the additions in my last patch.


  reply	other threads:[~2007-03-07  5:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-27 19:24 [PATCH 0/3] Basic msi bug fixes Eric W. Biederman
2007-02-27 19:28 ` [PATCH 1/3] msi: Sanely support hardware level msi disabling Eric W. Biederman
2007-02-27 19:31   ` [PATCH 2/3] msi: Fixup the msi enable/disable logic Eric W. Biederman
2007-02-27 19:33     ` [PATCH 3/3] msi: Support masking msi irqs without a mask bit Eric W. Biederman
2007-03-02  2:26     ` [PATCH 2/3] msi: Fixup the msi enable/disable logic Michael Ellerman
2007-03-07  5:19       ` Eric W. Biederman [this message]
2007-03-07  8:51         ` Michael Ellerman
2007-03-02 20:52 ` [PATCH 0/3] Basic msi bug fixes Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 2/3] msi:  Fixup the msi enable/disable logic' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).