LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Chandramouli Narayanan <mouli@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, ak@suse.de, akpm@linux-foundation.org
Subject: Re: [PATCH 2.6.21 3/3] x86_64: EFI64 support
Date: Fri, 01 Jun 2007 12:52:07 -0600	[thread overview]
Message-ID: <m1y7j3zew8.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070501190111.145499000@em64tdvp.jf.intel.com> (Chandramouli Narayanan's message of "Tue, 01 May 2007 11:59:48 -0700")

Chandramouli Narayanan <mouli@linux.intel.com> writes:

> +
> +static int __init efifb_init(void)
> +{
> +	int ret;
> +
> +	if (!efi_enabled)
> +		return -ENODEV;
> +

Please remove this efi_enabled check it appears  redundant with
the check immediately below.

> +	if (screen_info.orig_video_isVGA != VIDEO_TYPE_EFI)
> +		return -ENODEV;
> +
> +
> +	ret = platform_driver_register(&efifb_driver);
> +
> +	if (!ret) {
> +		ret = platform_device_register(&efifb_device);
> +		if (ret)
> +			platform_driver_unregister(&efifb_driver);
> +	}
> +	return ret;
> +}
> +module_init(efifb_init);

Eric



      reply	other threads:[~2007-06-01 18:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-01 18:59 [PATCH 2.6.21 0/3] " Chandramouli Narayanan
2007-05-01 18:59 ` [PATCH 2.6.21 1/3] " Chandramouli Narayanan
2007-05-03  2:56   ` Randy Dunlap
2007-05-03 19:20     ` chandramouli narayanan
2007-05-03 20:15       ` Randy Dunlap
2007-06-01 16:47       ` Yinghai Lu
2007-05-04 13:01   ` Andi Kleen
2007-05-25 22:46     ` chandramouli narayanan
2007-06-01 18:39   ` Eric W. Biederman
2007-06-01 18:44   ` Eric W. Biederman
2007-05-01 18:59 ` [PATCH 2.6.21 2/3] " Chandramouli Narayanan
2007-05-02 20:55   ` Andi Kleen
2007-05-02 22:43     ` chandramouli narayanan
2007-06-01 18:50   ` Eric W. Biederman
2007-05-01 18:59 ` [PATCH 2.6.21 3/3] " Chandramouli Narayanan
2007-06-01 18:52   ` Eric W. Biederman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1y7j3zew8.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mouli@linux.intel.com \
    --subject='Re: [PATCH 2.6.21 3/3] x86_64: EFI64 support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).