LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo
@ 2021-10-06  6:04 Krzysztof Hałasa
  2021-10-06  6:17 ` Ahmad Fatoum
  2021-10-06  7:36 ` Lucas Stach
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Hałasa @ 2021-10-06  6:04 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer
  Cc: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	linux-arm-kernel, linux-kernel

Print i.MX6 "Solo" name in addition to the "Quad" and "DualLite"
for SOC_IMX6Q.

Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index b407b024dde3..b6f2f2ea8e65 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -143,7 +143,7 @@ config SOC_IMX6
 	select PL310_ERRATA_769419 if CACHE_L2X0
 
 config SOC_IMX6Q
-	bool "i.MX6 Quad/DualLite support"
+	bool "i.MX6 Quad/DualLite/Solo support"
 	select ARM_ERRATA_764369 if SMP
 	select ARM_ERRATA_754322
 	select ARM_ERRATA_775420
@@ -153,7 +153,7 @@ config SOC_IMX6Q
 	select SOC_IMX6
 
 	help
-	  This enables support for Freescale i.MX6 Quad processor.
+	  This enables support for Freescale i.MX6 Quad/DualLite/Solo processors.
 
 config SOC_IMX6SL
 	bool "i.MX6 SoloLite support"
diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
index 11dcc369ec14..8cc8a2ed1d12 100644
--- a/arch/arm/mach-imx/mach-imx6q.c
+++ b/arch/arm/mach-imx/mach-imx6q.c
@@ -217,7 +217,7 @@ static const char * const imx6q_dt_compat[] __initconst = {
 	NULL,
 };
 
-DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite (Device Tree)")
+DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite/Solo (Device Tree)")
 	.l2c_aux_val 	= 0,
 	.l2c_aux_mask	= ~0,
 	.smp		= smp_ops(imx_smp_ops),

-- 
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo
  2021-10-06  6:04 [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo Krzysztof Hałasa
@ 2021-10-06  6:17 ` Ahmad Fatoum
  2021-10-06  7:36 ` Lucas Stach
  1 sibling, 0 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2021-10-06  6:17 UTC (permalink / raw)
  To: Krzysztof Hałasa, Shawn Guo, Sascha Hauer
  Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team,
	Pengutronix Kernel Team, linux-kernel

Hello Krzysztof,

On 06.10.21 08:04, Krzysztof Hałasa wrote:
> Print i.MX6 "Solo" name in addition to the "Quad" and "DualLite"
> for SOC_IMX6Q.
If you think enumerating all variants is worthwhile, you should
probably be adding normal Dual (Quad, but with only 2 cores) as well.

> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index b407b024dde3..b6f2f2ea8e65 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -143,7 +143,7 @@ config SOC_IMX6
>  	select PL310_ERRATA_769419 if CACHE_L2X0
>  
>  config SOC_IMX6Q
> -	bool "i.MX6 Quad/DualLite support"
> +	bool "i.MX6 Quad/DualLite/Solo support"
>  	select ARM_ERRATA_764369 if SMP
>  	select ARM_ERRATA_754322
>  	select ARM_ERRATA_775420
> @@ -153,7 +153,7 @@ config SOC_IMX6Q
>  	select SOC_IMX6
>  
>  	help
> -	  This enables support for Freescale i.MX6 Quad processor.
> +	  This enables support for Freescale i.MX6 Quad/DualLite/Solo processors.
>  
>  config SOC_IMX6SL
>  	bool "i.MX6 SoloLite support"
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
> index 11dcc369ec14..8cc8a2ed1d12 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -217,7 +217,7 @@ static const char * const imx6q_dt_compat[] __initconst = {
>  	NULL,
>  };
>  
> -DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite (Device Tree)")
> +DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite/Solo (Device Tree)")
>  	.l2c_aux_val 	= 0,
>  	.l2c_aux_mask	= ~0,
>  	.smp		= smp_ops(imx_smp_ops),
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo
  2021-10-06  6:04 [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo Krzysztof Hałasa
  2021-10-06  6:17 ` Ahmad Fatoum
@ 2021-10-06  7:36 ` Lucas Stach
  2021-10-06  8:17   ` Krzysztof Hałasa
  1 sibling, 1 reply; 4+ messages in thread
From: Lucas Stach @ 2021-10-06  7:36 UTC (permalink / raw)
  To: Krzysztof Hałasa, Shawn Guo, Sascha Hauer
  Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team,
	Pengutronix Kernel Team, linux-kernel

Am Mittwoch, dem 06.10.2021 um 08:04 +0200 schrieb Krzysztof Hałasa:
> Print i.MX6 "Solo" name in addition to the "Quad" and "DualLite"
> for SOC_IMX6Q.
> 
I don't think that's helpful, you would need to at least also print
"Dual" to make it correct. The Solo is just a fused down version of the
DualLite, just as the Dual is a fused down version of the Quad.

Quad/DualLite refers to the two different die versions of the chip.

Regards,
Lucas

> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index b407b024dde3..b6f2f2ea8e65 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -143,7 +143,7 @@ config SOC_IMX6
>  	select PL310_ERRATA_769419 if CACHE_L2X0
>  
>  config SOC_IMX6Q
> -	bool "i.MX6 Quad/DualLite support"
> +	bool "i.MX6 Quad/DualLite/Solo support"
>  	select ARM_ERRATA_764369 if SMP
>  	select ARM_ERRATA_754322
>  	select ARM_ERRATA_775420
> @@ -153,7 +153,7 @@ config SOC_IMX6Q
>  	select SOC_IMX6
>  
>  	help
> -	  This enables support for Freescale i.MX6 Quad processor.
> +	  This enables support for Freescale i.MX6 Quad/DualLite/Solo processors.
>  
>  config SOC_IMX6SL
>  	bool "i.MX6 SoloLite support"
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
> index 11dcc369ec14..8cc8a2ed1d12 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -217,7 +217,7 @@ static const char * const imx6q_dt_compat[] __initconst = {
>  	NULL,
>  };
>  
> -DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite (Device Tree)")
> +DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite/Solo (Device Tree)")
>  	.l2c_aux_val 	= 0,
>  	.l2c_aux_mask	= ~0,
>  	.smp		= smp_ops(imx_smp_ops),
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo
  2021-10-06  7:36 ` Lucas Stach
@ 2021-10-06  8:17   ` Krzysztof Hałasa
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Hałasa @ 2021-10-06  8:17 UTC (permalink / raw)
  To: Lucas Stach
  Cc: Shawn Guo, Sascha Hauer, linux-arm-kernel, Fabio Estevam,
	NXP Linux Team, Pengutronix Kernel Team, linux-kernel

Lucas Stach <l.stach@pengutronix.de> writes:

>> Print i.MX6 "Solo" name in addition to the "Quad" and "DualLite"
>> for SOC_IMX6Q.
>> 
> I don't think that's helpful, you would need to at least also print
> "Dual" to make it correct. The Solo is just a fused down version of the
> DualLite, just as the Dual is a fused down version of the Quad.
>
> Quad/DualLite refers to the two different die versions of the chip.

Perhaps we need to print Dual as well.

ATM "cat /proc/cpuinfo" (and everything using it) prints "Freescale
i.MX6 Quad/DualLite (Device Tree)" on Solo and this is, at best,
misleading: making people wonder what CPU do they really have.
-- 
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-06  8:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06  6:04 [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo Krzysztof Hałasa
2021-10-06  6:17 ` Ahmad Fatoum
2021-10-06  7:36 ` Lucas Stach
2021-10-06  8:17   ` Krzysztof Hałasa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).