LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@dabbelt.com>
To: mcroce@linux.microsoft.com
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, Atish Patra <Atish.Patra@wdc.com>,
kernel@esmil.dk, akira.tsukamoto@gmail.com, drew@beagleboard.org,
bmeng.cn@gmail.com, David.Laight@aculab.com, guoren@kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] riscv: use the generic string routines
Date: Fri, 10 Sep 2021 20:49:02 -0700 (PDT) [thread overview]
Message-ID: <mhng-22e6331c-16e1-40cc-b431-4990fda46ecf@palmerdabbelt-glaptop> (raw)
In-Reply-To: <CAFnufp0eVejrDJoGE900D2U5-9qi-srVEmPOc9zHC5mSH4DgLg@mail.gmail.com>
On Thu, 05 Aug 2021 03:31:04 PDT (-0700), mcroce@linux.microsoft.com wrote:
> On Wed, Aug 4, 2021 at 10:40 PM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>>
>> On Tue, 03 Aug 2021 09:54:34 PDT (-0700), mcroce@linux.microsoft.com wrote:
>> > On Mon, Jul 19, 2021 at 1:44 PM Matteo Croce <mcroce@linux.microsoft.com> wrote:
>> >>
>> >> From: Matteo Croce <mcroce@microsoft.com>
>> >>
>> >> Use the generic routines which handle alignment properly.
>> >>
>> >> These are the performances measured on a BeagleV machine for a
>> >> 32 mbyte buffer:
>> >>
>> >> memcpy:
>> >> original aligned: 75 Mb/s
>> >> original unaligned: 75 Mb/s
>> >> new aligned: 114 Mb/s
>> >> new unaligned: 107 Mb/s
>> >>
>> >> memset:
>> >> original aligned: 140 Mb/s
>> >> original unaligned: 140 Mb/s
>> >> new aligned: 241 Mb/s
>> >> new unaligned: 241 Mb/s
>> >>
>> >> TCP throughput with iperf3 gives a similar improvement as well.
>> >>
>> >> This is the binary size increase according to bloat-o-meter:
>> >>
>> >> add/remove: 0/0 grow/shrink: 4/2 up/down: 432/-36 (396)
>> >> Function old new delta
>> >> memcpy 36 324 +288
>> >> memset 32 148 +116
>> >> strlcpy 116 132 +16
>> >> strscpy_pad 84 96 +12
>> >> strlcat 176 164 -12
>> >> memmove 76 52 -24
>> >> Total: Before=1225371, After=1225767, chg +0.03%
>> >>
>> >> Signed-off-by: Matteo Croce <mcroce@microsoft.com>
>> >> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
>> >> ---
>> >
>> > Hi,
>> >
>> > can someone have a look at this change and share opinions?
>>
>> This LGTM. How are the generic string routines landing? I'm happy to
>> take this into my for-next, but IIUC we need the optimized generic
>> versions first so we don't have a performance regression falling back to
>> the trivial ones for a bit. Is there a shared tag I can pull in?
>
> Hi,
>
> I see them only in linux-next by now.
These ended up getting rejected by Linus, so I'm going to hold off on
this for now. If they're really out of lib/ then I'll take the C
routines in arch/riscv, but either way it's an issue for the next
release.
next prev parent reply other threads:[~2021-09-11 3:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 11:43 Matteo Croce
2021-08-03 16:54 ` Matteo Croce
2021-08-04 20:40 ` Palmer Dabbelt
2021-08-05 8:20 ` David Laight
2021-08-05 10:31 ` Matteo Croce
2021-09-11 3:49 ` Palmer Dabbelt [this message]
2021-09-11 17:26 ` David Laight
2021-09-12 0:10 ` Guo Ren
2021-09-13 11:35 ` David Laight
2021-09-19 19:13 ` Matteo Croce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-22e6331c-16e1-40cc-b431-4990fda46ecf@palmerdabbelt-glaptop \
--to=palmer@dabbelt.com \
--cc=Atish.Patra@wdc.com \
--cc=David.Laight@aculab.com \
--cc=akira.tsukamoto@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=bmeng.cn@gmail.com \
--cc=drew@beagleboard.org \
--cc=guoren@kernel.org \
--cc=hch@infradead.org \
--cc=kernel@esmil.dk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mcroce@linux.microsoft.com \
--cc=paul.walmsley@sifive.com \
--subject='Re: [PATCH] riscv: use the generic string routines' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).