LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1
@ 2021-07-02  1:43 Bin Meng
  2021-07-02  1:43 ` [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node Bin Meng
  2021-07-08 13:40 ` [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
  0 siblings, 2 replies; 11+ messages in thread
From: Bin Meng @ 2021-07-02  1:43 UTC (permalink / raw)
  To: Palmer Dabbelt, Lewis Hanly, Atish Patra, linux-kernel, linux-riscv
  Cc: Bin Meng

From: Bin Meng <bin.meng@windriver.com>

Per the DT spec, 'local-mac-address' is used to specify MAC address
that was assigned to the network device, while 'mac-address' is used
to specify the MAC address that was last used by the boot program,
and shall be used only if the value differs from 'local-mac-address'
property value.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
index 0659068b62f7..a9c558366d61 100644
--- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
+++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
@@ -317,7 +317,7 @@ emac1: ethernet@20112000 {
 			reg = <0x0 0x20112000 0x0 0x2000>;
 			interrupt-parent = <&plic>;
 			interrupts = <70 71 72 73>;
-			mac-address = [00 00 00 00 00 00];
+			local-mac-address = [00 00 00 00 00 00];
 			clocks = <&clkcfg 5>, <&clkcfg 2>;
 			status = "disabled";
 			clock-names = "pclk", "hclk";
-- 
2.25.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node
  2021-07-02  1:43 [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
@ 2021-07-02  1:43 ` Bin Meng
  2021-07-09 10:06   ` Conor.Dooley
  2021-07-16  9:23   ` Geert Uytterhoeven
  2021-07-08 13:40 ` [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
  1 sibling, 2 replies; 11+ messages in thread
From: Bin Meng @ 2021-07-02  1:43 UTC (permalink / raw)
  To: Palmer Dabbelt, Lewis Hanly, Atish Patra, linux-kernel, linux-riscv
  Cc: Bin Meng

From: Bin Meng <bin.meng@windriver.com>

U-Boot expects this alias to be in place in order to fix up the mac
address of the ethernet node.

Note on the Icicle Kit board, currently only emac1 is enabled so it
becomes the 'ethernet0'.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
index a9c558366d61..16cc6573107b 100644
--- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
+++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
@@ -9,6 +9,10 @@ / {
 	model = "Microchip MPFS Icicle Kit";
 	compatible = "microchip,mpfs-icicle-kit";
 
+	aliases {
+		ethernet0 = &emac1;
+	};
+
 	chosen {
 	};
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1
  2021-07-02  1:43 [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
  2021-07-02  1:43 ` [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node Bin Meng
@ 2021-07-08 13:40 ` Bin Meng
  2021-07-09  9:20   ` Conor.Dooley
  1 sibling, 1 reply; 11+ messages in thread
From: Bin Meng @ 2021-07-08 13:40 UTC (permalink / raw)
  To: Palmer Dabbelt, Lewis Hanly, Atish Patra, linux-kernel, linux-riscv
  Cc: Bin Meng

On Fri, Jul 2, 2021 at 9:42 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> Per the DT spec, 'local-mac-address' is used to specify MAC address
> that was assigned to the network device, while 'mac-address' is used
> to specify the MAC address that was last used by the boot program,
> and shall be used only if the value differs from 'local-mac-address'
> property value.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
>  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Ping?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1
  2021-07-08 13:40 ` [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
@ 2021-07-09  9:20   ` Conor.Dooley
  0 siblings, 0 replies; 11+ messages in thread
From: Conor.Dooley @ 2021-07-09  9:20 UTC (permalink / raw)
  To: bmeng.cn, palmer, Lewis.Hanly, atish.patra, linux-kernel, linux-riscv
  Cc: bin.meng

On 08/07/2021 14:40, Bin Meng wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Fri, Jul 2, 2021 at 9:42 AM Bin Meng<bmeng.cn@gmail.com>  wrote:
>> From: Bin Meng<bin.meng@windriver.com>
>>
>> Per the DT spec, 'local-mac-address' is used to specify MAC address
>> that was assigned to the network device, while 'mac-address' is used
>> to specify the MAC address that was last used by the boot program,
>> and shall be used only if the value differs from 'local-mac-address'
>> property value.
>>
>> Signed-off-by: Bin Meng<bin.meng@windriver.com>
>> ---
>>
>>   arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> Ping?
Yeah, thats fine.
Reviewed-by: conor dooley <conor.dooley@microchip.com>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node
  2021-07-02  1:43 ` [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node Bin Meng
@ 2021-07-09 10:06   ` Conor.Dooley
  2021-07-16  9:23   ` Geert Uytterhoeven
  1 sibling, 0 replies; 11+ messages in thread
From: Conor.Dooley @ 2021-07-09 10:06 UTC (permalink / raw)
  To: bmeng.cn, palmer, Lewis.Hanly, atish.patra, linux-kernel, linux-riscv
  Cc: bin.meng

On 02/07/2021 02:43, Bin Meng wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Bin Meng <bin.meng@windriver.com>
>
> U-Boot expects this alias to be in place in order to fix up the mac
> address of the ethernet node.
>
> Note on the Icicle Kit board, currently only emac1 is enabled so it
> becomes the 'ethernet0'.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
>   arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> index a9c558366d61..16cc6573107b 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> @@ -9,6 +9,10 @@ / {
>          model = "Microchip MPFS Icicle Kit";
>          compatible = "microchip,mpfs-icicle-kit";
>
> +       aliases {
> +               ethernet0 = &emac1;
> +       };
> +
>          chosen {
>          };

Sure.
Reviewed-by: conor dooley<conor.dooley@microchip.com>

> --
> 2.25.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node
  2021-07-02  1:43 ` [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node Bin Meng
  2021-07-09 10:06   ` Conor.Dooley
@ 2021-07-16  9:23   ` Geert Uytterhoeven
  2021-07-16 10:14     ` Bin Meng
  1 sibling, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2021-07-16  9:23 UTC (permalink / raw)
  To: Bin Meng
  Cc: Palmer Dabbelt, Lewis Hanly, Atish Patra,
	Linux Kernel Mailing List, linux-riscv, Bin Meng

Hi Bing,

On Fri, Jul 2, 2021 at 3:44 AM Bin Meng <bmeng.cn@gmail.com> wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> U-Boot expects this alias to be in place in order to fix up the mac
> address of the ethernet node.
>
> Note on the Icicle Kit board, currently only emac1 is enabled so it
> becomes the 'ethernet0'.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>

Thanks for your patch!

> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> @@ -9,6 +9,10 @@ / {
>         model = "Microchip MPFS Icicle Kit";
>         compatible = "microchip,mpfs-icicle-kit";
>
> +       aliases {
> +               ethernet0 = &emac1;
> +       };
> +
>         chosen {
>         };

This should be added to the board DTS (microchip-mpfs-icicle-kit.dts)
instead.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node
  2021-07-16  9:23   ` Geert Uytterhoeven
@ 2021-07-16 10:14     ` Bin Meng
  2021-07-16 11:34       ` Geert Uytterhoeven
  0 siblings, 1 reply; 11+ messages in thread
From: Bin Meng @ 2021-07-16 10:14 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Palmer Dabbelt, Lewis Hanly, Atish Patra,
	Linux Kernel Mailing List, linux-riscv, Bin Meng

Hi Geert,

On Fri, Jul 16, 2021 at 5:23 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Bing,
>
> On Fri, Jul 2, 2021 at 3:44 AM Bin Meng <bmeng.cn@gmail.com> wrote:
> > From: Bin Meng <bin.meng@windriver.com>
> >
> > U-Boot expects this alias to be in place in order to fix up the mac
> > address of the ethernet node.
> >
> > Note on the Icicle Kit board, currently only emac1 is enabled so it
> > becomes the 'ethernet0'.
> >
> > Signed-off-by: Bin Meng <bin.meng@windriver.com>
>
> Thanks for your patch!

Thanks for the review!

>
> > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> > @@ -9,6 +9,10 @@ / {
> >         model = "Microchip MPFS Icicle Kit";
> >         compatible = "microchip,mpfs-icicle-kit";
> >
> > +       aliases {
> > +               ethernet0 = &emac1;
> > +       };
> > +
> >         chosen {
> >         };
>
> This should be added to the board DTS (microchip-mpfs-icicle-kit.dts)
> instead.

I was wondering the same thing before doing this, but when I checked
all other DTS in arch/riscv/boot I found the aliases node is put in
the SoC dtsi file instead of the board on so I think that's the
convention.

Regards,
Bin

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node
  2021-07-16 10:14     ` Bin Meng
@ 2021-07-16 11:34       ` Geert Uytterhoeven
  2021-08-04  3:55         ` Palmer Dabbelt
  0 siblings, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2021-07-16 11:34 UTC (permalink / raw)
  To: Bin Meng
  Cc: Palmer Dabbelt, Lewis Hanly, Atish Patra,
	Linux Kernel Mailing List, linux-riscv, Bin Meng

Hi Bin,

On Fri, Jul 16, 2021 at 12:14 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> On Fri, Jul 16, 2021 at 5:23 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Fri, Jul 2, 2021 at 3:44 AM Bin Meng <bmeng.cn@gmail.com> wrote:
> > > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> > > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> > > @@ -9,6 +9,10 @@ / {
> > >         model = "Microchip MPFS Icicle Kit";
> > >         compatible = "microchip,mpfs-icicle-kit";
> > >
> > > +       aliases {
> > > +               ethernet0 = &emac1;
> > > +       };
> > > +
> > >         chosen {
> > >         };
> >
> > This should be added to the board DTS (microchip-mpfs-icicle-kit.dts)
> > instead.
>
> I was wondering the same thing before doing this, but when I checked
> all other DTS in arch/riscv/boot I found the aliases node is put in
> the SoC dtsi file instead of the board on so I think that's the
> convention.

The numbering of the aliases is supposed to match the labels on the
board, hence it is board-specific, not SoC-specific.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node
  2021-07-16 11:34       ` Geert Uytterhoeven
@ 2021-08-04  3:55         ` Palmer Dabbelt
  2021-08-04  3:55           ` Bin Meng
  0 siblings, 1 reply; 11+ messages in thread
From: Palmer Dabbelt @ 2021-08-04  3:55 UTC (permalink / raw)
  To: geert
  Cc: bmeng.cn, lewis.hanly, Atish Patra, linux-kernel, linux-riscv, bin.meng

On Fri, 16 Jul 2021 04:34:02 PDT (-0700), geert@linux-m68k.org wrote:
> Hi Bin,
>
> On Fri, Jul 16, 2021 at 12:14 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>> On Fri, Jul 16, 2021 at 5:23 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> > On Fri, Jul 2, 2021 at 3:44 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>> > > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> > > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> > > @@ -9,6 +9,10 @@ / {
>> > >         model = "Microchip MPFS Icicle Kit";
>> > >         compatible = "microchip,mpfs-icicle-kit";
>> > >
>> > > +       aliases {
>> > > +               ethernet0 = &emac1;
>> > > +       };
>> > > +
>> > >         chosen {
>> > >         };
>> >
>> > This should be added to the board DTS (microchip-mpfs-icicle-kit.dts)
>> > instead.
>>
>> I was wondering the same thing before doing this, but when I checked
>> all other DTS in arch/riscv/boot I found the aliases node is put in
>> the SoC dtsi file instead of the board on so I think that's the
>> convention.
>
> The numbering of the aliases is supposed to match the labels on the
> board, hence it is board-specific, not SoC-specific.
>
> Gr{oetje,eeting}s,
>
>                         Geert

I don't see a v2 of this.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node
  2021-08-04  3:55         ` Palmer Dabbelt
@ 2021-08-04  3:55           ` Bin Meng
  2021-08-04  4:18             ` Palmer Dabbelt
  0 siblings, 1 reply; 11+ messages in thread
From: Bin Meng @ 2021-08-04  3:55 UTC (permalink / raw)
  To: Palmer Dabbelt
  Cc: Geert Uytterhoeven, Lewis Hanly, Atish Patra, linux-kernel,
	linux-riscv, Bin Meng

On Wed, Aug 4, 2021 at 11:55 AM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
> On Fri, 16 Jul 2021 04:34:02 PDT (-0700), geert@linux-m68k.org wrote:
> > Hi Bin,
> >
> > On Fri, Jul 16, 2021 at 12:14 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >> On Fri, Jul 16, 2021 at 5:23 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >> > On Fri, Jul 2, 2021 at 3:44 AM Bin Meng <bmeng.cn@gmail.com> wrote:
> >> > > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> >> > > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> >> > > @@ -9,6 +9,10 @@ / {
> >> > >         model = "Microchip MPFS Icicle Kit";
> >> > >         compatible = "microchip,mpfs-icicle-kit";
> >> > >
> >> > > +       aliases {
> >> > > +               ethernet0 = &emac1;
> >> > > +       };
> >> > > +
> >> > >         chosen {
> >> > >         };
> >> >
> >> > This should be added to the board DTS (microchip-mpfs-icicle-kit.dts)
> >> > instead.
> >>
> >> I was wondering the same thing before doing this, but when I checked
> >> all other DTS in arch/riscv/boot I found the aliases node is put in
> >> the SoC dtsi file instead of the board on so I think that's the
> >> convention.
> >
> > The numbering of the aliases is supposed to match the labels on the
> > board, hence it is board-specific, not SoC-specific.
> >
> > Gr{oetje,eeting}s,
> >
> >                         Geert
>
> I don't see a v2 of this.

Will send v2 soon.

Regards,
Bin

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node
  2021-08-04  3:55           ` Bin Meng
@ 2021-08-04  4:18             ` Palmer Dabbelt
  0 siblings, 0 replies; 11+ messages in thread
From: Palmer Dabbelt @ 2021-08-04  4:18 UTC (permalink / raw)
  To: bmeng.cn
  Cc: geert, lewis.hanly, Atish Patra, linux-kernel, linux-riscv, bin.meng

On Tue, 03 Aug 2021 20:55:56 PDT (-0700), bmeng.cn@gmail.com wrote:
> On Wed, Aug 4, 2021 at 11:55 AM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>>
>> On Fri, 16 Jul 2021 04:34:02 PDT (-0700), geert@linux-m68k.org wrote:
>> > Hi Bin,
>> >
>> > On Fri, Jul 16, 2021 at 12:14 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>> >> On Fri, Jul 16, 2021 at 5:23 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> >> > On Fri, Jul 2, 2021 at 3:44 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>> >> > > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> >> > > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> >> > > @@ -9,6 +9,10 @@ / {
>> >> > >         model = "Microchip MPFS Icicle Kit";
>> >> > >         compatible = "microchip,mpfs-icicle-kit";
>> >> > >
>> >> > > +       aliases {
>> >> > > +               ethernet0 = &emac1;
>> >> > > +       };
>> >> > > +
>> >> > >         chosen {
>> >> > >         };
>> >> >
>> >> > This should be added to the board DTS (microchip-mpfs-icicle-kit.dts)
>> >> > instead.
>> >>
>> >> I was wondering the same thing before doing this, but when I checked
>> >> all other DTS in arch/riscv/boot I found the aliases node is put in
>> >> the SoC dtsi file instead of the board on so I think that's the
>> >> convention.
>> >
>> > The numbering of the aliases is supposed to match the labels on the
>> > board, hence it is board-specific, not SoC-specific.
>> >
>> > Gr{oetje,eeting}s,
>> >
>> >                         Geert
>>
>> I don't see a v2 of this.
>
> Will send v2 soon.

Thanks.  I'm assuming you're going to send both patches.

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-08-04  4:18 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02  1:43 [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
2021-07-02  1:43 ` [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node Bin Meng
2021-07-09 10:06   ` Conor.Dooley
2021-07-16  9:23   ` Geert Uytterhoeven
2021-07-16 10:14     ` Bin Meng
2021-07-16 11:34       ` Geert Uytterhoeven
2021-08-04  3:55         ` Palmer Dabbelt
2021-08-04  3:55           ` Bin Meng
2021-08-04  4:18             ` Palmer Dabbelt
2021-07-08 13:40 ` [PATCH 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
2021-07-09  9:20   ` Conor.Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).