LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] x86/mm: vmemmap and vmalloc base addressess are usngined longs
Date: Thu, 26 Apr 2018 14:16:10 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.1804261415360.28147@cbobk.fhfr.pm> (raw)
In-Reply-To: <20180416094603.fj3wevho5j7wy7s6@black.fi.intel.com>

On Mon, 16 Apr 2018, Kirill A. Shutemov wrote:

> > > > Commits 9b46a051e4 ("x86/mm: Initialize vmemmap_base at boot-time") and 
> > > > a7412546d8 ("x86/mm: Adjust vmalloc base and size at boot-time") lost the 
> > > > type information for __VMALLOC_BASE_L4, __VMALLOC_BASE_L5, 
> > > > __VMEMMAP_BASE_L4 and __VMEMMAP_BASE_L5 constants.
> > > > 
> > > > Let's declare them explicitly unsigned long again.
> > > 
> > > It is just cosmetics, right? I mean these literals are 'unsigned long'
> > > anyway.
> > 
> > Yeah, I can't imagine this particular case leading to any overflow 
> > scenario, as the literal is big enough to be automatically treated as 
> > unsigned long by the compiler, but it shuts up sparse which treats this as 
> > a generic case (where the missing UL might be a problem), and totally 
> > pollutes the build output.
> > 
> > Either we put the 'UL' there, or teach sparse about figuring out the 
> > 'closer bigger fitting type' for hexadecimal literals, which might be more 
> > tricky.
> 
> I don't have a problem with the patch:
> 
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

ping, please?

sparse build is still noisy like hell :/

Thanks,

-- 
Jiri Kosina
SUSE Labs

  parent reply	other threads:[~2018-04-26 12:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 12:39 Jiri Kosina
2018-04-12 14:28 ` Kirill A. Shutemov
2018-04-16  9:43   ` Jiri Kosina
2018-04-16  9:46     ` Kirill A. Shutemov
2018-04-19  6:35       ` Jiri Kosina
2018-04-26 12:16       ` Jiri Kosina [this message]
2018-04-26 12:50         ` Thomas Gleixner
2018-04-16 11:57     ` Luc Van Oostenryck
2018-04-26 13:00 ` [tip:x86/urgent] x86/mm: Make vmemmap and vmalloc base address constants unsigned long tip-bot for Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.1804261415360.28147@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH] x86/mm: vmemmap and vmalloc base addressess are usngined longs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).