LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: goodix: Use the devm variant of regulator_register_notifier()
Date: Wed, 28 Jul 2021 11:49:10 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2107281149050.8253@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210720090736.1.Idc6db7d0f2c2ecc6e533e5b918a651a66f337b2f@changeid>

On Tue, 20 Jul 2021, Douglas Anderson wrote:

> In commit 18eeef46d359 ("HID: i2c-hid: goodix: Tie the reset line to
> true state of the regulator") I added a call to
> regulator_register_notifier() but no call to unregister. That's a
> bug. Let's use the devm variant to handle the unregistering.
> 
> Fixes: 18eeef46d359 ("HID: i2c-hid: goodix: Tie the reset line to true state of the regulator")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> 
>  drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c
> index 31a4c229fdb7..52674149a275 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c
> @@ -132,7 +132,7 @@ static int i2c_hid_of_goodix_probe(struct i2c_client *client,
>  	 */
>  	mutex_lock(&ihid_goodix->regulator_mutex);
>  	ihid_goodix->nb.notifier_call = ihid_goodix_vdd_notify;
> -	ret = regulator_register_notifier(ihid_goodix->vdd, &ihid_goodix->nb);
> +	ret = devm_regulator_register_notifier(ihid_goodix->vdd, &ihid_goodix->nb);
>  	if (ret) {
>  		mutex_unlock(&ihid_goodix->regulator_mutex);
>  		return dev_err_probe(&client->dev, ret,

Applied, thanks Doug.

-- 
Jiri Kosina
SUSE Labs


      reply	other threads:[~2021-07-28  9:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 16:07 Douglas Anderson
2021-07-28  9:49 ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2107281149050.8253@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dianders@chromium.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] HID: i2c-hid: goodix: Use the devm variant of regulator_register_notifier()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).