LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Michael Zaidman <michael.zaidman@gmail.com>
Cc: benjamin.tissoires@redhat.com, aaron.jones@ftdichip.com,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] HID: ft260: fix device removal due to USB disconnect
Date: Thu, 29 Jul 2021 12:39:03 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2107291238490.8253@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210729102603.3844-1-michael.zaidman@gmail.com>

On Thu, 29 Jul 2021, Michael Zaidman wrote:

> This commit fixes a functional regression introduced by the commit 82f09a637dd3
> ("HID: ft260: improve error handling of ft260_hid_feature_report_get()")
> when upon USB disconnect, the FTDI FT260 i2c device is still available within
> the /dev folder.
> 
> In my company's product, where the host USB to FT260 USB connection is
> hard-wired in the PCB, the issue is not reproducible. To reproduce it, I used
> the VirtualBox Ubuntu 20.04 VM and the UMFT260EV1A development module for the
> FTDI FT260 chip:
> 
> Plug the UMFT260EV1A module into a USB port and attach it to VM.
> 
> The VM shows 2 i2c devices under the /dev:
>     michael@michael-VirtualBox:~$ ls /dev/i2c-*
>     /dev/i2c-0  /dev/i2c-1
> 
> The i2c-0 is not related to the FTDI FT260:
>     michael@michael-VirtualBox:~$ cat /sys/bus/i2c/devices/i2c-0/name
>     SMBus PIIX4 adapter at 4100
> 
> The i2c-1 is created by hid-ft260.ko:
>     michael@michael-VirtualBox:~$ cat /sys/bus/i2c/devices/i2c-1/name
>     FT260 usb-i2c bridge on hidraw1
> 
> Now, detach the FTDI FT260 USB device from VM. We expect the /dev/i2c-1
> to disappear, but it's still here:
>     michael@michael-VirtualBox:~$ ls /dev/i2c-*
>     /dev/i2c-0  /dev/i2c-1
> 
> And the kernel log shows:
>     [  +0.001202] usb 2-2: USB disconnect, device number 3
>     [  +0.000109] ft260 0003:0403:6030.0002: failed to retrieve system status
>     [  +0.000316] ft260 0003:0403:6030.0003: failed to retrieve system status
> 
> It happens because the commit 82f09a637dd3 changed the ft260_get_system_config()
> return logic. This caused the ft260_is_interface_enabled() to exit with error
> upon the FT260 device USB disconnect, which in turn, aborted the ft260_remove()
> before deleting the FT260 i2c device and cleaning its sysfs stuff.
> 
> This commit restores the FT260 USB removal functionality and improves the
> ft260_is_interface_enabled() code to handle correctly all chip modes defined
> by the device interface configuration pins DCNF0 and DCNF1.
> 
> Signed-off-by: Michael Zaidman <michael.zaidman@gmail.com>
> Acked-by: Aaron Jones (FTDI-UK) <aaron.jones@ftdichip.com>

Thanks for the respin. Queued in for-5.14/upstream-fixes.

-- 
Jiri Kosina
SUSE Labs


      reply	other threads:[~2021-07-29 10:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 14:49 [PATCH v1] " Michael Zaidman
2021-07-28  9:47 ` Jiri Kosina
2021-07-29 10:26   ` [PATCH v2] " Michael Zaidman
2021-07-29 10:39     ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2107291238490.8253@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=aaron.jones@ftdichip.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.zaidman@gmail.com \
    --subject='Re: [PATCH v2] HID: ft260: fix device removal due to USB disconnect' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).