LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Dennis Zhou <dennisszhou@gmail.com>
Cc: Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/percpu.c: use smarter memory allocation for struct pcpu_alloc_info
Date: Tue, 3 Oct 2017 20:13:37 -0400 (EDT) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1710032011070.5407@knanqh.ubzr> (raw)
In-Reply-To: <20171003234801.GA1571@Big-Sky.local>
On Tue, 3 Oct 2017, Dennis Zhou wrote:
> Hi Tejun,
>
> On Tue, Oct 03, 2017 at 03:36:42PM -0700, Tejun Heo wrote:
> > > Subject: [PATCH] percpu: don't forget to free the temporary struct pcpu_alloc_info
> >
> > So, IIRC, the error path is either boot fail or some serious bug in
> > arch code. It really doesn't matter whether we free a page or not.
> >
>
> In setup_per_cpu_area, a call to either pcpu_embed_first_chunk,
> pcpu_page_first_chunk, or pcpu_setup_first_chunk is made. The first two
> eventually call pcpu_setup_first_chunk with a pairing call to
> pcpu_free_alloc_info right after. This occurs in all implementations. It
> happens we don't have a pairing call to pcpu_free_alloc_info in the UP
> setup_per_cpu_area.
That was my conclusion too (albeit not stated as clearly) and what my
second patch fixed.
Nicolas
next prev parent reply other threads:[~2017-10-04 0:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 20:57 [PATCH] mm/percpu.c: use smarter memory allocation for struct pcpu_alloc_info Nicolas Pitre
2017-10-03 21:05 ` Tejun Heo
2017-10-03 22:29 ` Nicolas Pitre
2017-10-03 22:36 ` Tejun Heo
2017-10-03 23:48 ` Dennis Zhou
2017-10-04 0:13 ` Nicolas Pitre [this message]
2017-10-04 14:15 ` Tejun Heo
2017-11-18 18:25 ` mm/percpu.c: use smarter memory allocation for struct pcpu_alloc_info (crisv32 hang) Guenter Roeck
2017-11-19 20:36 ` Nicolas Pitre
2017-11-20 2:03 ` Guenter Roeck
2017-11-20 4:08 ` Nicolas Pitre
2017-11-20 5:05 ` Guenter Roeck
2017-11-20 18:18 ` Nicolas Pitre
2017-11-20 18:51 ` Guenter Roeck
2017-11-20 20:21 ` Nicolas Pitre
2017-11-20 21:11 ` Guenter Roeck
2017-11-21 0:28 ` Nicolas Pitre
2017-11-21 1:48 ` Guenter Roeck
2017-11-21 3:50 ` Nicolas Pitre
2017-11-22 15:34 ` Jesper Nilsson
2017-11-22 20:17 ` Nicolas Pitre
2017-11-23 7:56 ` Jesper Nilsson
2017-11-27 19:41 ` Tejun Heo
2017-11-27 20:31 ` Nicolas Pitre
2017-11-27 20:33 ` Tejun Heo
2017-11-27 20:51 ` Nicolas Pitre
2017-11-27 20:54 ` Tejun Heo
2017-11-27 21:11 ` Guenter Roeck
2017-11-28 8:19 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1710032011070.5407@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=cl@linux.com \
--cc=dennisszhou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).