LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] add task handling notifier: base definitions
Date: Sat, 22 Dec 2007 00:32:20 +0100	[thread overview]
Message-ID: <p7363yrfwu3.fsf@bingen.suse.de> (raw)
In-Reply-To: <476A7832.76E4.0078.0@novell.com> (Jan Beulich's message of "Thu\, 20 Dec 2007 13\:12\:02 +0000")

"Jan Beulich" <jbeulich@novell.com> writes:

> This is the base patch, adding notification for task creation and
> deletion.

I like the basic concept. At some point I suspect we'll even need
a per task dynamic data allocator, that would remove even
more cruft.

Could you change the block notifier calls first to not take their lock
when there is nothing in the list (the common case)? It is 
weird that they don't already do this, but they should definitely
here.

I think the use of the blocking/atomic notifiers needs some comment.
I think I understand why you did it -- exit atomic because sleeping
in exit can be illegal and blocking for fork to allow GFP_KERNEL
allocations -- but that should be documented somewhere.

-Andi

  reply	other threads:[~2007-12-21 23:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-20 13:12 [PATCH 1/4] add task handling notifier: base definitions Jan Beulich
2007-12-21 23:32 ` Andi Kleen [this message]
2008-01-09  4:28 ` Matthew Helsley
2008-01-09  9:46   ` Jan Beulich
2008-01-23 19:11     ` Matt Helsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p7363yrfwu3.fsf@bingen.suse.de \
    --to=andi@firstfloor.org \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).