LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
	Adam Belay <abelay@novell.com>,
	linux-pm@lists.linux-foundation.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] cpuidle: avoid singing capacitors
Date: Mon, 03 Mar 2008 13:36:50 +0100	[thread overview]
Message-ID: <p73mypg6l25.fsf@bingen.suse.de> (raw)
In-Reply-To: <20080229193812.31f45b0c@mjolnir.drzeus.cx> (Pierre Ossman's message of "Fri\, 29 Feb 2008 19\:38\:12 +0100")

Pierre Ossman <drzeus-list@drzeus.cx> writes:

> Many devices today are of a less than stellar quality, and singing
> transistors are a common problem. A high-pitch noise is created, caused
> by power fluctuations as the processor enters and leaves deep sleep at
> a high frequency.
>
> Instead of just disabling the deep sleep (which wastes power). This
> patch merely reduces the number of times it is entered so that the
> frequency doesn't exceed 500 Hz. That should make sure the problem is
> inaudible.
>
> Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
> --
>
> The basic idea is above, but the implementation doesn't quite work. It seems jiffies is not a good time source in this scenario. The time spent in C3 takes a much bigger hit than I expect. The fact that powertop says that it has an average residency of 200 ms in C2 tells me that those should have been spent in C3.

I like the patch in principle, although I think the threshold should
be configurable, not hard coded.

I haven't checked in detail if that is the case, but you need to make
sure that you only reference jiffies on idle exit after the clock
source has caught up with lost jiffies after idle. That might be 
the cause of your problem.

-Andi

  parent reply	other threads:[~2008-03-03 12:37 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-29 18:38 Pierre Ossman
2008-02-29 21:44 ` Lennart Sorensen
2008-03-01 12:31   ` Pierre Ossman
2008-03-01 13:40 ` Pierre Ossman
2008-03-02  2:27 ` Lee Revell
2008-03-02 14:17   ` Pierre Ossman
2008-03-03 12:36 ` Andi Kleen [this message]
2008-03-03 20:18 ` [PATCH] " Pierre Ossman
2008-03-03 20:46   ` Pavel Machek
2008-03-03 21:03     ` Pierre Ossman
2008-03-03 21:08       ` Pavel Machek
2008-03-03 21:14         ` Pallipadi, Venkatesh
2008-03-03 21:17           ` Pierre Ossman
2008-03-03 22:04             ` Pallipadi, Venkatesh
2008-03-03 23:05               ` [linux-pm] " Alan Stern
2008-03-03 23:10                 ` Andi Kleen
2008-03-04  4:00                   ` Dave Jones
2008-03-04  6:14                     ` Pierre Ossman
2008-03-04 17:19                       ` Pierre Ossman
2008-03-04 17:29                         ` Andi Kleen
2008-03-04 17:30                           ` Pierre Ossman
2008-03-04 17:43                             ` Andi Kleen
2008-03-04 18:04                               ` Pierre Ossman
2008-03-04 18:34                                 ` Andi Kleen
2008-03-05  6:04                                   ` Pierre Ossman
2008-03-05 15:48                                     ` Andi Kleen
2008-03-05 16:53                                       ` Pierre Ossman
2008-03-05 17:32                                         ` Andi Kleen
2008-03-04 19:01                         ` Pallipadi, Venkatesh
2008-03-05  6:02                           ` Pierre Ossman
2008-03-05  8:40                             ` Pierre Ossman
2008-03-05  9:03                               ` Pavel Machek
2008-03-05 13:42                                 ` Pierre Ossman
2008-03-05 13:47                                   ` Pavel Machek
2008-03-05 13:52                                     ` Pierre Ossman
2008-03-06  8:27                               ` Pierre Ossman
2008-03-09 14:16                                 ` Pierre Ossman
2008-03-09 18:19                                   ` Rafael J. Wysocki
2008-03-09 18:50                                   ` Alan Stern
2008-03-09 19:30                                   ` Henrique de Moraes Holschuh
2008-03-09 20:14                                     ` Pierre Ossman
2008-03-09 20:41                                       ` Henrique de Moraes Holschuh
2008-03-09 20:54                                         ` Henrique de Moraes Holschuh
2008-03-10 10:00                                   ` Pavel Machek
2008-03-10 12:49                                     ` Pierre Ossman
2008-03-10 13:04                                       ` Andi Kleen
2008-03-10 13:29                                         ` Pierre Ossman
2008-03-12 19:11                                       ` Len Brown
2008-03-13  8:10                                         ` Pavel Machek
2008-03-13 10:42                                           ` Andi Kleen
2008-03-14  4:13                                             ` Len Brown
2008-03-13 16:34                                         ` Pierre Ossman
2008-03-13 16:47                                           ` Pallipadi, Venkatesh
2008-03-13 17:44                                             ` Pierre Ossman
2008-03-13 17:49                                           ` Pierre Ossman
2008-03-14 19:40                                           ` Pierre Ossman
2008-03-14 21:15                                             ` Pallipadi, Venkatesh
2008-03-15  0:41                                               ` Pierre Ossman
2008-03-11  7:51                                   ` Pierre Ossman
2008-03-11 10:48                                     ` Andi Kleen
2008-03-11 15:20                                       ` Pierre Ossman
2008-03-11 17:31                                         ` Pierre Ossman
2008-03-12 19:17                                       ` Len Brown
2008-03-12 20:31                               ` Len Brown
2008-03-04  9:40                     ` Andi Kleen
2008-03-03 23:09               ` Andi Kleen
     [not found] <a2itf-5jB-27@gated-at.bofh.it>
2008-02-29 21:09 ` [RFC][PATCH] " Alan Jenkins
2008-03-01 12:29   ` Pierre Ossman
2008-03-05 17:32     ` Jeremy Fitzhardinge
2008-03-05 18:01       ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73mypg6l25.fsf@bingen.suse.de \
    --to=andi@firstfloor.org \
    --cc=abelay@novell.com \
    --cc=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=venkatesh.pallipadi@intel.com \
    --subject='Re: [RFC][PATCH] cpuidle: avoid singing capacitors' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).