LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Frederik Himpe <fhimpe@telenet.be>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] [TCP]: Must count fack_count also when skipping
Date: Mon, 24 Mar 2008 20:36:08 +0000 (UTC) [thread overview]
Message-ID: <pan.2008.03.24.20.36.07@telenet.be> (raw)
In-Reply-To: <Pine.LNX.4.64.0803031541230.28251@kivilampi-30.cs.helsinki.fi>
On Mon, 03 Mar 2008 15:53:12 +0200, Ilpo Järvinen
wrote:
> [PATCH net-2.6] [TCP]: Must count fack_count also when skipping
>
> It makes fackets_out to grow too slowly compared with the real write
> queue.
>
> This shouldn't cause those BUG_TRAP(packets <= tp->packets_out) to
> trigger but how knows how such inconsistent fackets_out affects here and
> there around TCP when everything is nowadays assuming accurate
> fackets_out. So lets see if this silences them all.
>
> Reported by Guillaume Chazarain <guichaz@gmail.com>.
Will this patch be applied to 2.6.24 stable? I think I have been hit by
the same problem recently:
WARNING: at net/ipv4/tcp_input.c:2054 tcp_mark_head_lost()
Pid: 16959, comm: X Tainted: P 2.6.24.3-desktop-3mnb #1
Call Trace:
<IRQ> [<ffffffff8045550c>] tcp_ack+0x180c/0x1d60
[<ffffffff80494259>] _read_lock_bh+0x9/0x20
[<ffffffff80458075>] tcp_rcv_state_process+0x3b5/0xd00
[<ffffffff8045f818>] tcp_v4_do_rcv+0xc8/0x3f0
[<ffffffff885601b3>] :nf_conntrack_ipv4:ipv4_confirm+0x33/0x60
[<ffffffff8043c316>] nf_iterate+0x66/0xc0
[<ffffffff804621b8>] tcp_v4_rcv+0x898/0xaf0
[<ffffffff80442ec3>] ip_local_deliver_finish+0xc3/0x250
[<ffffffff80442b64>] ip_rcv_finish+0x114/0x3b0
[<ffffffff80443365>] ip_rcv+0x205/0x2f0
[<ffffffff8041c45c>] netif_receive_skb+0x3ac/0x490
[<ffffffff88184509>] :forcedeth:nv_napi_poll+0xf9/0x850
[<ffffffff8041eaa8>] net_rx_action+0x128/0x230
[<ffffffff802412a5>] __do_softirq+0x75/0xe0
[<ffffffff8020d4fc>] call_softirq+0x1c/0x30
[<ffffffff8020f6c5>] do_softirq+0x35/0x90
[<ffffffff80241228>] irq_exit+0x88/0x90
[<ffffffff8020f910>] do_IRQ+0x80/0x100
[<ffffffff8020c881>] ret_from_intr+0x0/0xa
<EOI>
WARNING: at net/ipv4/tcp_input.c:2413 tcp_fastretrans_alert()
Pid: 4053, comm: rsyslogd Tainted: P 2.6.24.3-desktop-3mnb #1
Call Trace:
<IRQ> [<ffffffff80455a2d>] tcp_ack+0x1d2d/0x1d60
[<ffffffff80494259>] _read_lock_bh+0x9/0x20
[<ffffffff80458075>] tcp_rcv_state_process+0x3b5/0xd00
[<ffffffff8045f818>] tcp_v4_do_rcv+0xc8/0x3f0
[<ffffffff885601b3>] :nf_conntrack_ipv4:ipv4_confirm+0x33/0x60
[<ffffffff8043c316>] nf_iterate+0x66/0xc0
[<ffffffff804621b8>] tcp_v4_rcv+0x898/0xaf0
[<ffffffff80442ec3>] ip_local_deliver_finish+0xc3/0x250
[<ffffffff80442b64>] ip_rcv_finish+0x114/0x3b0
[<ffffffff80443365>] ip_rcv+0x205/0x2f0
[<ffffffff8041c45c>] netif_receive_skb+0x3ac/0x490
[<ffffffff88184509>] :forcedeth:nv_napi_poll+0xf9/0x850
[<ffffffff8041eaa8>] net_rx_action+0x128/0x230
[<ffffffff802412a5>] __do_softirq+0x75/0xe0
[<ffffffff8020d4fc>] call_softirq+0x1c/0x30
[<ffffffff8020f6c5>] do_softirq+0x35/0x90
[<ffffffff80241228>] irq_exit+0x88/0x90
[<ffffffff8020f910>] do_IRQ+0x80/0x100
[<ffffffff8020c881>] ret_from_intr+0x0/0xa
<EOI>
--
Frederik Himpe
next prev parent reply other threads:[~2008-03-24 20:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 4:04 WARNING: at net/ipv4/tcp_input.c:2054 tcp_mark_head_lost() Giangiacomo Mariotti
2008-02-23 8:03 ` Andrew Morton
2008-02-27 9:29 ` Ilpo Järvinen
2008-02-27 18:56 ` Guillaume Chazarain
2008-02-27 19:29 ` Ilpo Järvinen
2008-02-28 8:22 ` Ilpo Järvinen
2008-02-29 1:10 ` Andrew Morton
2008-02-29 4:35 ` Bill Fink
2008-02-29 12:24 ` Ilpo Järvinen
2008-03-02 12:20 ` Guillaume Chazarain
2008-03-02 12:38 ` Ilpo Järvinen
2008-03-02 13:15 ` Guillaume Chazarain
2008-03-02 19:51 ` Ilpo Järvinen
2008-03-03 8:32 ` Ilpo Järvinen
2008-03-03 13:40 ` Ilpo Järvinen
2008-03-03 13:53 ` [PATCH net-2.6] [TCP]: Must count fack_count also when skipping Ilpo Järvinen
2008-03-03 20:11 ` David Miller
2008-03-24 20:36 ` Frederik Himpe [this message]
2008-03-24 21:41 ` David Miller
2008-03-25 21:24 ` Ilpo Järvinen
2008-03-26 3:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pan.2008.03.24.20.36.07@telenet.be \
--to=fhimpe@telenet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--subject='Re: [PATCH net-2.6] [TCP]: Must count fack_count also when skipping' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).