LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Enable 4-speaker output for Dell XPS 15 9510 laptop
@ 2021-08-14 22:46 Kristin Paget
  2021-08-15  7:30 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Kristin Paget @ 2021-08-14 22:46 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel, Jaroslav Kysela, linux-kernel

The 2021-model XPS 15 appears to use the same 4-speakers-on-ALC289 audio
setup as the Precision models, so requires the same quirk to enable woofer
output. Tested on my own 9510.

Signed-off-by: Kristin Paget <kristin@tombom.co.uk>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 218d1aa0fd14..8b72064f8321 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8319,6 +8319,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
        SND_PCI_QUIRK(0x1028, 0x0a2e, "Dell", ALC236_FIXUP_DELL_AIO_HEADSET_MIC),
        SND_PCI_QUIRK(0x1028, 0x0a30, "Dell", ALC236_FIXUP_DELL_AIO_HEADSET_MIC),
        SND_PCI_QUIRK(0x1028, 0x0a58, "Dell", ALC255_FIXUP_DELL_HEADSET_MIC),
+       SND_PCI_QUIRK(0x1028, 0x0a61, "Dell XPS 15 9510", ALC289_FIXUP_DUAL_SPK),
        SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
        SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
        SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Enable 4-speaker output for Dell XPS 15 9510 laptop
  2021-08-14 22:46 [PATCH] ALSA: hda/realtek: Enable 4-speaker output for Dell XPS 15 9510 laptop Kristin Paget
@ 2021-08-15  7:30 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2021-08-15  7:30 UTC (permalink / raw)
  To: Kristin Paget; +Cc: Takashi Iwai, alsa-devel, Jaroslav Kysela, linux-kernel

On Sun, 15 Aug 2021 00:46:05 +0200,
Kristin Paget wrote:
> 
> The 2021-model XPS 15 appears to use the same 4-speakers-on-ALC289 audio
> setup as the Precision models, so requires the same quirk to enable woofer
> output. Tested on my own 9510.
> 
> Signed-off-by: Kristin Paget <kristin@tombom.co.uk>

It seems that your MUA broken the patch (tabs converted to spaces).
Since it's a trivial oneliner, I applied manually.  But for the next
time, please try to fix your MUA setup.

Thanks!

Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-15  7:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-14 22:46 [PATCH] ALSA: hda/realtek: Enable 4-speaker output for Dell XPS 15 9510 laptop Kristin Paget
2021-08-15  7:30 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).