LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Tony Luck <tony.luck@intel.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Isaku Yamahata <yamahata@valinux.co.jp>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Fix section type conflict in arch/ia64/xen/xen_pv_ops.c
Date: Thu, 06 Nov 2008 17:48:00 +0100 [thread overview]
Message-ID: <s5h1vxou7gf.wl%tiwai@suse.de> (raw)
__initdata and const cannot be always a happy pair, as gcc-4.3.3 gives
the compile errors like:
arch/ia64/xen/xen_pv_ops.c:156: error: xen_init_ops causes a section type conflict
arch/ia64/xen/xen_pv_ops.c:340: error: xen_iosapic_ops causes a section type conflict
This patch simply removes const from data with __initdata.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
diff --git a/arch/ia64/xen/xen_pv_ops.c b/arch/ia64/xen/xen_pv_ops.c
index 04cd123..5d491d9 100644
--- a/arch/ia64/xen/xen_pv_ops.c
+++ b/arch/ia64/xen/xen_pv_ops.c
@@ -153,7 +153,7 @@ xen_post_smp_prepare_boot_cpu(void)
xen_setup_vcpu_info_placement();
}
-static const struct pv_init_ops xen_init_ops __initdata = {
+static struct pv_init_ops xen_init_ops __initdata = {
.banner = xen_banner,
.reserve_memory = xen_reserve_memory,
@@ -260,7 +260,7 @@ xen_intrin_local_irq_restore(unsigned long mask)
xen_rsm_i();
}
-static const struct pv_cpu_ops xen_cpu_ops __initdata = {
+static struct pv_cpu_ops xen_cpu_ops __initdata = {
.fc = xen_fc,
.thash = xen_thash,
.get_cpuid = xen_get_cpuid,
@@ -337,7 +337,7 @@ xen_iosapic_write(char __iomem *iosapic, unsigned int reg, u32 val)
HYPERVISOR_physdev_op(PHYSDEVOP_apic_write, &apic_op);
}
-static const struct pv_iosapic_ops xen_iosapic_ops __initdata = {
+static struct pv_iosapic_ops xen_iosapic_ops __initdata = {
.pcat_compat_init = xen_pcat_compat_init,
.__get_irq_chip = xen_iosapic_get_irq_chip,
next reply other threads:[~2008-11-06 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 16:48 Takashi Iwai [this message]
2008-11-06 18:57 ` Jeremy Fitzhardinge
2008-11-06 19:15 ` Takashi Iwai
2008-11-06 21:48 ` Sam Ravnborg
2008-11-11 7:51 ` Takashi Iwai
2008-11-11 8:15 ` Isaku Yamahata
2008-11-11 8:18 ` Takashi Iwai
2008-11-11 8:56 ` Isaku Yamahata
2008-11-11 17:43 ` Jeremy Fitzhardinge
2008-11-11 17:45 ` Takashi Iwai
2008-11-11 18:47 ` Jeremy Fitzhardinge
2008-11-11 19:04 ` Takashi Iwai
2008-11-12 18:19 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1vxou7gf.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=yamahata@valinux.co.jp \
--subject='Re: [PATCH] Fix section type conflict in arch/ia64/xen/xen_pv_ops.c' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).