LKML Archive on
help / color / mirror / Atom feed
From: Takashi Iwai <>
To: " Gustavo A. R. Silva " <>
Cc: "Jaroslav Kysela" <>, <>,
Subject: Re: [PATCH] ALSA: Use struct_size() helper
Date: Fri, 24 May 2019 07:55:21 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20190523202917.GA12595@embeddedor>

On Thu, 23 May 2019 22:29:17 +0200,
 Gustavo A. R. Silva  wrote:
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes, in particular in the
> context in which this code is being used.
> So, replace the following form:
> sizeof(struct rate_priv) + src_format->channels * sizeof(struct rate_channel)
> with:
> struct_size(data, channels, src_format->channels)
> This code was detected with the help of Coccinelle.
> Signed-off-by: Gustavo A. R. Silva <>

Applied now, thanks.


      reply	other threads:[~2019-05-24  5:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 20:29 Gustavo A. R. Silva
2019-05-24  5:55 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] ALSA: Use struct_size() helper' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).