LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH][RFC] Sound, Xonar, CS43xx: Don't overrun static array
@ 2011-01-20 21:37 Jesper Juhl
  2011-01-22 13:55 ` Clemens Ladisch
  2011-01-22 16:24 ` Takashi Iwai
  0 siblings, 2 replies; 3+ messages in thread
From: Jesper Juhl @ 2011-01-20 21:37 UTC (permalink / raw)
  To: linux-kernel; +Cc: alsa-devel, Takashi Iwai, Jaroslav Kysela, Clemens Ladisch


'cs4398_regs' in 'struct xonar_cs43xx' is an array of 'u8' with a size of 
8. So, this code in sound/pci/oxygen/xonar_cs43xx.c::dump_d1_registers()

    		for (i = 2; i <= 8; ++i)
	  			snd_iprintf(buffer, " %02x", data->cs4398_regs[i]);

will overrun the array when 'i == 8'.

I guess that what's needed to fix it is the trivial patch below, but I 
must admit that I have no idea about this code, so I may very well be 
wrong. Additionally, I have no way to actually test this, so all I know is 
that the below compiles. Someone who actually knows this code should take 
a look before anything is comitted - consider the below (not much more 
than) a bug report.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 xonar_cs43xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/oxygen/xonar_cs43xx.c b/sound/pci/oxygen/xonar_cs43xx.c
index 9f72d42..2527191 100644
--- a/sound/pci/oxygen/xonar_cs43xx.c
+++ b/sound/pci/oxygen/xonar_cs43xx.c
@@ -392,7 +392,7 @@ static void dump_d1_registers(struct oxygen *chip,
 	unsigned int i;
 
 	snd_iprintf(buffer, "\nCS4398: 7?");
-	for (i = 2; i <= 8; ++i)
+	for (i = 2; i < 8; ++i)
 		snd_iprintf(buffer, " %02x", data->cs4398_regs[i]);
 	snd_iprintf(buffer, "\n");
 	dump_cs4362a_registers(data, buffer);

-- 
Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][RFC] Sound, Xonar, CS43xx: Don't overrun static array
  2011-01-20 21:37 [PATCH][RFC] Sound, Xonar, CS43xx: Don't overrun static array Jesper Juhl
@ 2011-01-22 13:55 ` Clemens Ladisch
  2011-01-22 16:24 ` Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: Clemens Ladisch @ 2011-01-22 13:55 UTC (permalink / raw)
  To: Jesper Juhl, linux-kernel; +Cc: alsa-devel, Takashi Iwai, Jaroslav Kysela

Jesper Juhl wrote:
> 'cs4398_regs' in 'struct xonar_cs43xx' is an array of 'u8' with a size of 
> 8. So, this code in sound/pci/oxygen/xonar_cs43xx.c::dump_d1_registers()
> 
>     		for (i = 2; i <= 8; ++i)
> 	  			snd_iprintf(buffer, " %02x", data->cs4398_regs[i]);
> 
> will overrun the array when 'i == 8'.
> 
> I guess that what's needed to fix it is the trivial patch below, but I 
> must admit that I have no idea about this code, so I may very well be 
> wrong. Additionally, I have no way to actually test this, so all I know is 
> that the below compiles. Someone who actually knows this code should take 
> a look before anything is comitted - consider the below (not much more 
> than) a bug report.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Acked-by: Clemens Ladisch <clemens@ladisch.de>

> ---
>  xonar_cs43xx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/oxygen/xonar_cs43xx.c
> b/sound/pci/oxygen/xonar_cs43xx.c
> index 9f72d42..2527191 100644
> --- a/sound/pci/oxygen/xonar_cs43xx.c
> +++ b/sound/pci/oxygen/xonar_cs43xx.c
> @@ -392,7 +392,7 @@ static void dump_d1_registers(struct oxygen *chip,
>  	unsigned int i;
>  
>  	snd_iprintf(buffer, "\nCS4398: 7?");
> -       for (i = 2; i <= 8; ++i)
> +       for (i = 2; i < 8; ++i)
>  		snd_iprintf(buffer, " %02x", data->cs4398_regs[i]);
>  	snd_iprintf(buffer, "\n");
>  	dump_cs4362a_registers(data, buffer);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][RFC] Sound, Xonar, CS43xx: Don't overrun static array
  2011-01-20 21:37 [PATCH][RFC] Sound, Xonar, CS43xx: Don't overrun static array Jesper Juhl
  2011-01-22 13:55 ` Clemens Ladisch
@ 2011-01-22 16:24 ` Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2011-01-22 16:24 UTC (permalink / raw)
  To: Jesper Juhl; +Cc: linux-kernel, alsa-devel, Jaroslav Kysela, Clemens Ladisch

At Thu, 20 Jan 2011 22:37:43 +0100 (CET),
Jesper Juhl wrote:
> 
> 
> 'cs4398_regs' in 'struct xonar_cs43xx' is an array of 'u8' with a size of 
> 8. So, this code in sound/pci/oxygen/xonar_cs43xx.c::dump_d1_registers()
> 
>     		for (i = 2; i <= 8; ++i)
> 	  			snd_iprintf(buffer, " %02x", data->cs4398_regs[i]);
> 
> will overrun the array when 'i == 8'.
> 
> I guess that what's needed to fix it is the trivial patch below, but I 
> must admit that I have no idea about this code, so I may very well be 
> wrong. Additionally, I have no way to actually test this, so all I know is 
> that the below compiles. Someone who actually knows this code should take 
> a look before anything is comitted - consider the below (not much more 
> than) a bug report.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Applied now.  Thanks.


Takashi

> ---
>  xonar_cs43xx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/oxygen/xonar_cs43xx.c b/sound/pci/oxygen/xonar_cs43xx.c
> index 9f72d42..2527191 100644
> --- a/sound/pci/oxygen/xonar_cs43xx.c
> +++ b/sound/pci/oxygen/xonar_cs43xx.c
> @@ -392,7 +392,7 @@ static void dump_d1_registers(struct oxygen *chip,
>  	unsigned int i;
>  
>  	snd_iprintf(buffer, "\nCS4398: 7?");
> -	for (i = 2; i <= 8; ++i)
> +	for (i = 2; i < 8; ++i)
>  		snd_iprintf(buffer, " %02x", data->cs4398_regs[i]);
>  	snd_iprintf(buffer, "\n");
>  	dump_cs4362a_registers(data, buffer);
> 
> -- 
> Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
> Plain text mails only, please.
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-01-22 16:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-20 21:37 [PATCH][RFC] Sound, Xonar, CS43xx: Don't overrun static array Jesper Juhl
2011-01-22 13:55 ` Clemens Ladisch
2011-01-22 16:24 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).