LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, Greg KH <greg@kroah.com>
Subject: Re: sound: struct device - replace bus_id with dev_name(),	dev_set_name()
Date: Mon, 03 Nov 2008 09:06:12 +0100	[thread overview]
Message-ID: <s5h3ai9w7wr.wl%tiwai@suse.de> (raw)
In-Reply-To: <s5hy702ide3.wl%tiwai@suse.de>

At Sun, 02 Nov 2008 12:19:16 +0100,
I wrote:
> 
> At Sun, 02 Nov 2008 03:50:35 +0100,
> Kay Sievers wrote:
> > 
> > --- a/sound/isa/ad1848/ad1848.c
> > +++ b/sound/isa/ad1848/ad1848.c
> > @@ -70,15 +70,15 @@ static int __devinit snd_ad1848_match(st
> >  		return 0;
> >  
> >  	if (port[n] == SNDRV_AUTO_PORT) {
> > -		snd_printk(KERN_ERR "%s: please specify port\n", dev->bus_id);
> > +		snd_printk(KERN_ERR "%s: please specify port\n", dev_name(dev));
> 
> All the changes in sound/isa/* seem to be better fixed by replacement
> with dev_err().
> 
> Other changes look good to me.

I dropped sound/isa/* changes from your patch and applied to sound git
tree now.

The sound/isa* parts are replacement with dev_err() and co as well, so
there is no longer dev->bus_id in sound directory.


thanks,

Takashi

  reply	other threads:[~2008-11-03  8:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-02  2:50 Kay Sievers
2008-11-02 11:19 ` Takashi Iwai
2008-11-03  8:06   ` Takashi Iwai [this message]
2008-11-03  8:35     ` Kay Sievers
  -- strict thread matches above, loose matches on Subject: below --
2008-10-30  1:27 Kay Sievers
2008-10-30  6:46 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h3ai9w7wr.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: sound: struct device - replace bus_id with dev_name(),	dev_set_name()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).