LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: <ayman.bagabas@gmail.com>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
	"Hui Wang" <hui.wang@canonical.com>,
	"Andy Shevchenko" <andy@infradead.org>,
	"Darren Hart" <dvhart@infradead.org>,
	"Jaroslav Kysela" <perex@perex.cz>, <kailang@realtek.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Platform Driver" <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] x86: add support for Huawei WMI hotkeys.
Date: Mon, 05 Nov 2018 12:05:22 +0100	[thread overview]
Message-ID: <s5h5zxb4wel.wl-tiwai@suse.de> (raw)
In-Reply-To: <3074f3045a43984fc9df4d4bb66d15e3f5293e90.camel@gmail.com>

On Sat, 03 Nov 2018 00:10:18 +0100,
<ayman.bagabas@gmail.com> wrote:
> 
> On Fri, 2018-11-02 at 20:20 +0200, Andy Shevchenko wrote:
> > > +#include <linux/input.h>
> > > +#include <linux/input/sparse-keymap.h>
> > > +#include <linux/acpi.h>
> > > +#include <linux/wmi.h>
> > 
> > Please, keep in order.
> 
> What order do I have to follow? Does this look right?
> module.h
> init.h
> apci.h
> wmi.h
> input.h
> sparse-keymap.h

A most common pattern is the alphabetical order.


thanks,

Takashi

  reply	other threads:[~2018-11-05 11:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02  4:11 [PATCH v2 0/3] Huawei laptops WMI & sound fixes Ayman Bagabas
2018-11-02  4:11 ` [PATCH v2 1/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
2018-11-02 18:20   ` Andy Shevchenko
2018-11-02 23:10     ` ayman.bagabas
2018-11-05 11:05       ` Takashi Iwai [this message]
2018-11-02  4:11 ` [PATCH v2 2/3] ALSA: hda: fix front speakers on Huawei MBXP Ayman Bagabas
2018-11-02 18:07   ` Andy Shevchenko
2018-11-02  4:11 ` [PATCH v2 3/3] ALSA: hda: add support for Huawei WMI MicMute LED Ayman Bagabas
2018-11-02 18:12   ` Andy Shevchenko
2018-11-02 18:30     ` Takashi Iwai
2018-11-02 18:33       ` Andy Shevchenko
2018-11-02 23:21     ` ayman.bagabas
2018-11-05 14:46       ` Andy Shevchenko
2018-11-02 18:05 ` [PATCH v2 0/3] Huawei laptops WMI & sound fixes Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h5zxb4wel.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@infradead.org \
    --cc=ayman.bagabas@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=hui.wang@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --subject='Re: [PATCH v2 1/3] x86: add support for Huawei WMI hotkeys.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).