From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=bKrn=NQ=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C1E42C0044C
	for <linux-kernel@archiver.kernel.org>; Mon,  5 Nov 2018 11:05:26 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 797ED20825
	for <linux-kernel@archiver.kernel.org>; Mon,  5 Nov 2018 11:05:26 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 797ED20825
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729086AbeKEUYe (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 5 Nov 2018 15:24:34 -0500
Received: from mx2.suse.de ([195.135.220.15]:52150 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1727275AbeKEUYe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Nov 2018 15:24:34 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay1.suse.de (unknown [195.135.220.254])
        by mx1.suse.de (Postfix) with ESMTP id AE65EACD0;
        Mon,  5 Nov 2018 11:05:23 +0000 (UTC)
Date:   Mon, 05 Nov 2018 12:05:22 +0100
Message-ID: <s5h5zxb4wel.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     <ayman.bagabas@gmail.com>
Cc:     "Andy Shevchenko" <andy.shevchenko@gmail.com>,
        "ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
        "Hui Wang" <hui.wang@canonical.com>,
        "Andy Shevchenko" <andy@infradead.org>,
        "Darren Hart" <dvhart@infradead.org>,
        "Jaroslav Kysela" <perex@perex.cz>, <kailang@realtek.com>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        "Platform Driver" <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] x86: add support for Huawei WMI hotkeys.
In-Reply-To: <3074f3045a43984fc9df4d4bb66d15e3f5293e90.camel@gmail.com>
References: <20181102041120.7603-1-ayman.bagabas@gmail.com>
        <20181102041120.7603-2-ayman.bagabas@gmail.com>
        <CAHp75Vds_RucAxD7ZHkRs8C32Y=UG3YQngGhZ28vvagVESTC_g@mail.gmail.com>
        <3074f3045a43984fc9df4d4bb66d15e3f5293e90.camel@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 03 Nov 2018 00:10:18 +0100,
<ayman.bagabas@gmail.com> wrote:
> 
> On Fri, 2018-11-02 at 20:20 +0200, Andy Shevchenko wrote:
> > > +#include <linux/input.h>
> > > +#include <linux/input/sparse-keymap.h>
> > > +#include <linux/acpi.h>
> > > +#include <linux/wmi.h>
> > 
> > Please, keep in order.
> 
> What order do I have to follow? Does this look right?
> module.h
> init.h
> apci.h
> wmi.h
> input.h
> sparse-keymap.h

A most common pattern is the alphabetical order.


thanks,

Takashi