LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Wouter Paesen <wouter@kangaroot.net>
Cc: Jaroslav Kysela <perex@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20] sound/pci/ca0106: add device attribute to ca0106 devices
Date: Mon, 12 Feb 2007 14:45:54 +0100	[thread overview]
Message-ID: <s5h64a7mqul.wl%tiwai@suse.de> (raw)
In-Reply-To: <20070209165211.GB15805@tougher.kangaroot.net>

At Fri, 9 Feb 2007 17:52:11 +0100,
Wouter Paesen wrote:
> 
> 
> The ca0106 driver does not install a reference to the pci
> device in it's __devinit function.   This will result in a 
> missing "device" attribute on the sound devices associated with
> this card, which makes hal/libhal ignore the card.
> 
> Signed-off-by: Wouter Paesen <wouter@kangaroot.net>

Thanks, it's already fixed in the latest git tree.


Takashi

> --
> 
> --- linux-2.6.20/sound/pci/ca0106/ca0106_main.c.orig	2007-02-04 19:44:54.000000000 +0100
> +++ linux-2.6.20/sound/pci/ca0106/ca0106_main.c	        2007-02-09 17:20:37.000000000 +0100
> @@ -1455,6 +1455,8 @@ static int __devinit snd_ca0106_create(i
>  		snd_ca0106_free(chip);
>  		return err;
>  	}
> +
> +	snd_card_set_dev(card, &pci->dev);
>  	*rchip = chip;
>  	return 0;
>  }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

      reply	other threads:[~2007-02-12 13:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 16:52 Wouter Paesen
2007-02-12 13:45 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h64a7mqul.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=wouter@kangaroot.net \
    --subject='Re: [PATCH 2.6.20] sound/pci/ca0106: add device attribute to ca0106 devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).